GithubHelp home page GithubHelp logo

Tests fail with out IDN about trurl HOT 7 CLOSED

jacobmealey avatar jacobmealey commented on September 28, 2024 1
Tests fail with out IDN

from trurl.

Comments (7)

bagder avatar bagder commented on September 28, 2024 1

Ah yes. We need to poll the used libcurl version for IDN support (using curl_version_info) and probably output that info somehow so that we can figure that out and then avoid those tests...

from trurl.

jacobmealey avatar jacobmealey commented on September 28, 2024 1

Would it make sense to just print the entirety of feature_names in the output of trurl --version? and then of course update tests.json to specify a specific feature and test.py to skip these features.

from trurl.

krishean avatar krishean commented on September 28, 2024

I ran into this as well when compiling libcurl as a static library on an ubuntu install that did not have libidn2-dev installed. I just installed the necessary package to get around it, but having a way to see what feature flags are enabled and be able to adjust what tests are run accordingly could be nice

from trurl.

krishean avatar krishean commented on September 28, 2024

Printing the feature names on a separate line like curl has could be parsed into an array or list in test.py and compared against an array in the json of features required by a given test

from trurl.

jacobmealey avatar jacobmealey commented on September 28, 2024

excellent, that's what I was thinking as well.
The only worry I have is that there are many features in curl that would be listed that aren't even touched in trurl. we wouldn't want to give a user the idea that trurl has some features (for example AsynchDNS) that it makes no use of, which seems like it would get confusing.

from trurl.

krishean avatar krishean commented on September 28, 2024

Maybe have a prefix at the beginning of the line such as "libcurl features: " to make sure the user is aware that they are inherited from libcurl, and not necessarily directly related to trurl?

from trurl.

bagder avatar bagder commented on September 28, 2024

I think we should only show features that are relevant for trurl, which for now only is IDN. Otherwise we will show a very long list of things that are irrelevant.

We could possibly convert some of our libcurl version-dependent things to instead become named features: normalize-ipv6, normalize-ipv4 for example.

from trurl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.