GithubHelp home page GithubHelp logo

Comments (3)

AndreasArvidsson avatar AndreasArvidsson commented on August 26, 2024

We also still have getNodeAtLocation on the language definitions interface. If we want to separate Tree sitter from the language definition we can't really return a Tree sitter syntax node :D

I think the right way of doing this is that once we have migrated all the scope handlers away from legacy we can remove get node at location and create a new Tree sitter package containing the language definitions implementation.
Maybe we can make a canonical tree representation that language definition can return for the parse tree action?

from cursorless.

pokey avatar pokey commented on August 26, 2024

yeah we prob should wait till all legacy languages migrated I guess?

Yeah not sure bout parse tree action. Was initially thinking that could be a custom action exposed by the same tree-sitter package that exposes the language definitions impl. I think we prob want to move to supporting actions defined outside of the engine as we move towards lean core

from cursorless.

AndreasArvidsson avatar AndreasArvidsson commented on August 26, 2024

That sound simplest and also the correct priority wise.

That is also one solution.

from cursorless.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.