GithubHelp home page GithubHelp logo

Comments (7)

cweiske avatar cweiske commented on September 28, 2024

Ah. So your proposal is the following:

If the value to be set is an object - but a subclass of stdClass - pass it directly to the setter method.

That makes sense. Could you add a test for this in your PR?

from jsonmapper.

radmen avatar radmen commented on September 28, 2024

Thanks for quick reply!

My idea is a bit different: if the value is object of the type which is requested simply pass it to the setter.

I'll create PR ASAP.

from jsonmapper.

cweiske avatar cweiske commented on September 28, 2024

✅ merged.

from jsonmapper.

cweiske avatar cweiske commented on September 28, 2024

@radmen: Take care of the next commit, netresearch@26294de - you have to convert your arrays to object to keep your code working.

from jsonmapper.

radmen avatar radmen commented on September 28, 2024

@cweiske is there something I should fix regarding the mentioned commit? I've ran the tests and everything seems to work fine.

Sorry for long reply, was on vacations :)

from jsonmapper.

cweiske avatar cweiske commented on September 28, 2024

No, not in jsonmapper. But in you application that uses jsonmapper.

This was just a hint.

from jsonmapper.

radmen avatar radmen commented on September 28, 2024

Ah ok :) Thanks for info!

from jsonmapper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.