Comments (3)
You are correct, my evaluation code is slightly different. After looking into this, it seems to me that their evaluation specification is badly designed.
As far as I can tell, in the official code, machine-given answers are normalized in several ways -- such as the removal of articles as you mention -- but the ground-truth answers it checks against only have their punctuation normalized. I made the assumption that you mention based on the fact that their evaluation would clearly be wrong if the ground truth is not normalized: if an unnormalized ground truth answer would be changed due to normalization if it were given as a machine answer, it is impossible for any machine-given answer to be considered equal to this ground truth answer. For example, if all ground truth answers are "the cat" and the machine predicts "the cat", then normalization will only change the machine answer to "cat", which is unequal to "the cat" and so receive a score of 0 in the official code.
As you correctly point out, the ground truth answers are indeed not normalized. This should mean that my code evaluates slightly more things to be correct (the ones where the normalization doesn't make a correct answer wrong) and that it might be worth filing an issue in their repository. A quick search through the data suggests that about 1750 questions in the training set are affected by this (most of them are answers that contain the word "one"). I would rather not introduce this "bug" into my code to make it equal to theirs.
from pytorch-vqa.
I agree the official method is broken. In my guess the original paper still used the old evaluation method, otherwise it cannot be compared to other papers.
You might want to clarify in README the list of differences to the paper (or any nontrivial assumption).
from pytorch-vqa.
I'll do that, thanks for flagging up these issues!
from pytorch-vqa.
Related Issues (20)
- when running preprocess_images.py, "size mismatch" occured HOT 1
- Large memory consume HOT 1
- Preprocessed path and vocabulary path issue HOT 3
- Issue with train_loader and val_loader in train.py HOT 2
- ssd create issue HOT 1
- why attention use '+' instead of '*' HOT 1
- Metric computation in training phase HOT 2
- EOFError: Ran out of input when training HOT 5
- concat or sum? HOT 4
- Runtime error with preprocess-images
- About attention showing in the pic
- Mismatch in Computing Accuracy HOT 1
- AttributeError: module ‘torchvision.transforms’ has no attribute ‘Scale’ HOT 3
- Training time HOT 4
- maximum q len HOT 2
- Information regarding training time HOT 1
- run without CUDA HOT 7
- Test the model HOT 5
- Working with abstract scenes VQA v1 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pytorch-vqa.