Psalm warning on release 2.2.0 about cyclonedx-php-library

[jkowalleck]

the parameter annotation is missing for a good reason> there is nothing to document.
the parameter is intended to be mixed. if it was not null, it is casted to string, using __toString() magic method, if needed.

furthermore, the following patch will confuse phpmd - which it was written for. there must be no space

-     * @SuppressWarnings(PHPMD.BooleanArgumentFlag)
-     * @SuppressWarnings(PHPMD.ElseExpression)
+     * @SuppressWarnings (PHPMD.BooleanArgumentFlag)
+     * @SuppressWarnings (PHPMD.ElseExpression)

---

please help reproducing this. i do not see any psalm warnings.
I do not see this issue, cannot reproduce

• Code Analysis (8.1, lowest)

  php tools/psalm/vendor/vimeo/psalm/psalm --php-version=8.1 --no-diff --no-cache --long-progress --output-format=github --report=CI_reports/psalm/php8.1_lowest.junit.xml --stats --shepherd
    shell: /usr/bin/bash -e {0}
    env:
      PHP_VERSION_LATEST: 8.2
      PHP_PROJECT_EXT: dom,json,libxml,simplexml
      REPORTS_DIR: CI_reports
      TESTS_REPORTS_ARTIFACT: tests-reports
      TYPES_REPORTS_ARTIFACT: types-reports
      COMPOSER_PROCESS_TIMEOUT: 0
      COMPOSER_NO_INTERACTION: 1
      COMPOSER_NO_AUDIT: 1
  Target PHP version: 8.1 (set by CLI argument) Enabled extensions: dom.
  Scanning files...
  Analyzing files...
  
  ░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░ 60 / 86 (69%)
  ░░░░░░░░░░░░░░░░░░░░░░░░░░
  🐑 results sent to shepherd.dev 🐑
  

• Code Analysis (8.2, highest)

  php tools/psalm/vendor/vimeo/psalm/psalm --php-version=8.2 --no-diff --no-cache --long-progress --output-format=github --report=CI_reports/psalm/php8.2_highest.junit.xml --stats --shepherd
    shell: /usr/bin/bash -e {0}
    env:
      PHP_VERSION_LATEST: 8.2
      PHP_PROJECT_EXT: dom,json,libxml,simplexml
      REPORTS_DIR: CI_reports
      TESTS_REPORTS_ARTIFACT: tests-reports
      TYPES_REPORTS_ARTIFACT: types-reports
      COMPOSER_PROCESS_TIMEOUT: 0
      COMPOSER_NO_INTERACTION: 1
      COMPOSER_NO_AUDIT: 1
  Target PHP version: 8.2 (set by CLI argument) Enabled extensions: dom.
  Scanning files...
  Analyzing files...
  
  ░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░ 60 / 86 (69%)
  ░░░░░░░░░░░░░░░░░░░░░░░░░░
  🐑 results sent to shepherd.dev 🐑
  

[llaville]

I saw it, because I run tests locally on my clone copy of this repo !

With : https://github.com/CycloneDX/cyclonedx-php-library/blob/v2.2.0/composer.json#L119

I've noticed that warning is shown only on first run (when no psalm cache dir exists).

With params used by CI, I've realized that warning is not display with --output-format=github option

[llaville]

To reproduce locally:

rm -rf .psalm.cache/
composer test:psalm

[llaville]

It come from Psalm itself: this warning is only display on console or phpstorm output format
See https://github.com/vimeo/psalm/blob/master/src/Psalm/IssueBuffer.php#L710

[jkowalleck]

thanks for the research.
will look into this and provide a fix

[jkowalleck]

just like in the screenshot from #313 (comment)
I was unable to get psalm to output the actual warning, and furthermore psalm still passed.

but i was able to provide a fix so that psalm did not output that it was able to fix something.