GithubHelp home page GithubHelp logo

Can't query experiments about cytoflow HOT 4 CLOSED

AlFontal avatar AlFontal commented on June 27, 2024
Can't query experiments

from cytoflow.

Comments (4)

kristjaneerik avatar kristjaneerik commented on June 27, 2024

Could you list all the columns in the underlying dataframe, e.g. by doing

print(ex.data.columns)

There are two things going on here. The error message you are seeing is due to a bug.

                raise util.CytoflowError("Tried to sanitize column name {1} to "
                                         "{2} but it already existed in the "
                                         " DataFrame."
                                         .format(name, new_name))

should read

                raise util.CytoflowError("Tried to sanitize column name {0} to "
                                         "{1} but it already existed in the "
                                         " DataFrame."
                                         .format(name, new_name))

But this piece of code is triggered by another issue, which is that two columns seem to be "sanitizing" to the same name. E.g. if you have a column "DNA positive" and then try to add a filter with the name "DNA_positive", they are distinct, but end up being sanitized to the same thing.

from cytoflow.

AlFontal avatar AlFontal commented on June 27, 2024

Hi @kristjaneerik!

Thanks, you were right, I messed up the channel naming when instantiating the experiment and two different channels had the same name. After fixing that, I can query now without issues. However, I think that:

  • We should fix the issue with the .format indexes that you specified, do you want to open a PR?
  • Maybe there should be a check at experiment definition that makes sure no two channels share the same name (or resolve to the same name after 'sanization'?)

from cytoflow.

bpteague avatar bpteague commented on June 27, 2024
  • We should fix the issue with the .format indexes that you specified, do you want to open a PR?

Yep, that's a bug. I'll fix it.

  • Maybe there should be a check at experiment definition that makes sure no two channels share the same name (or resolve to the same name after 'sanization'?)

Agreed. I'll add a test and a fix.

from cytoflow.

bpteague avatar bpteague commented on June 27, 2024

Fixed in fa4f593

from cytoflow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.