[bug] Amor not shown after twilight usage about legendofminetest

[D00Med]

Oh that's a problem, thanks for pointing it out.
I think I'll be removing the model change anyway, since it's buggy, the model isn't that great, and it doesn't work properly in multiplayer.

[mckaygerhard]

confirmed.. i hold a sword of wood, use the crystal and later when letf the crystal still are in the hand.. i dont have knowledge to fix this.. @D00Med unless you provided me some hints, must be marked as bug and heeds help wanted

[D00Med]

Setting player models and (or?) collision boxes changed in v 5.0 iirc, so this should have other problems.
I do not know how to fix it.

[mckaygerhard]

it's not about 5.X @D00Med .. lest remenbered that the deal is first stable for 0.4 and LATER FOR 0.5 so currently i dont care 5.X until i can bet the stability of the rest of bugs.. BUT: neither is a problem like this.. i noted that when i quit the Twilight Crystal entity or kills the entity the player the model updates . so maybe a missing callback or something i still does not understand about the api of the player

about the changes of 5.X the player api was splited in minetest game.. so the change now must detect as this example:

if minetest.global_exists("player_api") then
     player_api.register_model("skinsdb_3d_armor_character_5.b3d", { 
     ....
else
     default.player_register_model("skinsdb_3d_armor_character.b3d", {
     ...
end

or for set model is like this:

	if minetest.global_exists("player_api") then
		-- Minetest-5 compatible
		player_api.set_model(player, "skinsdb_3d_armor_character_5.b3d")
	else
		-- Minetest-0.4 compatible
		default.player_set_model(player, "skinsdb_3d_armor_character.b3d")
	end

we can create a compatibilty.lua file that wrap the funtions and redefineit as moany other mods do by example:

X = default.player_set_model(player, "skinsdb_3d_armor_character.b3d") or similar (i dont remenber where i see that but i am sure i see it)

(about the twillignht, puff incredible.. it helps a lot.. i will port to independent mod puff, but i want a timer to be temporal.. but currently i still not have the skills)

[D00Med]

https://github.com/D00Med/LegendofMinetest/blob/master/mods/twilight/init.lua

Looking at this, I'm not sure how there can still be a problem, all of the model changing code is commented out.

[mckaygerhard]

possible related to #49 already fixed.. i 'll check the references to model and updates later.. for now its working, i'll change the code to the suggestion on #6 (comment) to remain compatible