GithubHelp home page GithubHelp logo

Comments (7)

G-Rath avatar G-Rath commented on April 28, 2024 33

@mbostock I can understand not backporting for v1, but I ask you to reconsider for v2 because that's the highest major version supported by d3-interpolate and v3 of both packages switch to using ESM modules which we can't use in our applications and that libraries like recharts cannot use it either without switching to ESM themselves (which'd overall be very breaking)

I assume by forking you actually mean "fork + publish to npm", as that's the only way we could really try and address that ourselves, however it would be ideal if we could avoid having to do that since it just fragments the ecosystem further and then we'd need to convince libraries to move over to the new package (which wouldn't work because we'd need to either fork or backport for d3-interpolate as well)

I'm happy to help with this as much as possible, to reduce the burden on you.

Related recharts issue.

from d3-color.

timbset avatar timbset commented on April 28, 2024 17

@mbostock I created PR with cherry-pick to v2. Could you please merge it and publish new v2 version with vulnerability fix? It will simplify upgrade to more secure version of package for those who still use CommonJS

from d3-color.

timbset avatar timbset commented on April 28, 2024 14

We understand the motivation of staying on ESM-only approach. But some libs, like nanoid, promised to support older version for developers who cannot upgrade to ESM-only version. Why can't you do the same in this project? It would be responsible and respectful for people who use this lib.

from d3-color.

mbostock avatar mbostock commented on April 28, 2024 1

Iā€™m not going to do this but you are welcome to fork this repository.

from d3-color.

jayuen avatar jayuen commented on April 28, 2024

Thanks @AtishayMsft . I would also like the backport for version 1.4.x. Willing to help contribute to this.

from d3-color.

ndugger avatar ndugger commented on April 28, 2024

My team is blocked on this issue which is affecting the airbnb/visx package: airbnb/visx#1577

from d3-color.

JayWelsh avatar JayWelsh commented on April 28, 2024

For anyone that requires an immediate workaround for this, this method provided by haydn works wonders: airbnb/visx#1577 (comment)

from d3-color.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.