GithubHelp home page GithubHelp logo

Some contour polygon is reverse. about d3-contour HOT 5 OPEN

d3 avatar d3 commented on April 26, 2024
Some contour polygon is reverse.

from d3-contour.

Comments (5)

Fil avatar Fil commented on April 26, 2024

It seems that you are computing the contours on the spherical coordinates, then project the resulting polygons. But this creates issues with the holes. If you changed the order of operations (first project, then compute the contours), it would work. I'm sending you a suggestion.

See also https://observablehq.com/@d3/cloud-contours and https://observablehq.com/@fil/netcdf

from d3-contour.

stoneshell avatar stoneshell commented on April 26, 2024

It seems that you are computing the contours on the spherical coordinates, then project the resulting polygons. But this creates issues with the holes. If you changed the order of operations (first project, then compute the contours), it would work. I'm sending you a suggestion.

See also https://observablehq.com/@d3/cloud-contours and https://observablehq.com/@fil/netcdf

Thanks very much for your speedy and professional advice, I'm reading your code now, may get back to you if any further help needed.

Wish you a nice weekend ahead.

from d3-contour.

stoneshell avatar stoneshell commented on April 26, 2024

In the data source(contours.json), masked area(land) is set -1e20.
When I change -1e20 to -999, the chart becomes perfect.
I don't know why this value affect the contour polygons.

from d3-contour.

Fil avatar Fil commented on April 26, 2024

Ah, true:

contours = d3.contours()
                  .size([data.width, data.height])
                  .thresholds(thresholds)(varData.values.map(d => Math.max(-1e13, d)))

is correct, but with 1e-14 it's broken:

contours = d3.contours()
                  .size([data.width, data.height])
                  .thresholds(thresholds)(varData.values.map(d => Math.max(-1e14, d)))

from d3-contour.

mbostock avatar mbostock commented on April 26, 2024

I suspect that this is related to numerical instability and I think it’s unlikely that we would implement a fully robust algorithm. Maybe we can at least guarantee consistency with d3.polygonArea though.

from d3-contour.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.