GithubHelp home page GithubHelp logo

d3.geoRotation about d3-geo HOT 3 CLOSED

d3 avatar d3 commented on April 26, 2024
d3.geoRotation

from d3-geo.

Comments (3)

mbostock avatar mbostock commented on April 26, 2024 1

We’ll break the circular dependency. d3.geoRotation only depends on equirectangular out of convenience to define the inverse rotation. Instead of this:

d3_geo_identityRotation.invert = d3_geo_equirectangular;

It should be sufficient to say this:

d3_geo_identityRotation.invert = d3_geo_identityRotation;

from d3-geo.

chrisuehlinger avatar chrisuehlinger commented on April 26, 2024

Just a heads up, we're going to run into a circular dependency between d3.geoRotation, equirectangular and d3.geoProjection. If we're planning on breaking d3.geoProjection into a separate node module, that would also mean that people importing these modules could end up with a circular dependency (which could be problematic depending on how they bundle/load).

It's looking like the most straightforward way to resolve all of this is to keep d3.geoProjection in d3-geo (along with the "batteries included" projections like spherical and equirectangular, which are required in components like d3.geoPath and d3.geoCircle) and reserve d3-geo-projection for the more exotic projections (basically, the way things are now).

If you feel strongly that we should separate d3.geoProjection into d3-geo-projection, I'm cool with making that the focus of my next large effort. However, I do wonder whether there's much of a use case for d3-geo without any projections (you can't really render a map without them).

from d3-geo.

mbostock avatar mbostock commented on April 26, 2024

Fixed in #18 by @chrisuehlinger.

from d3-geo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.