GithubHelp home page GithubHelp logo

d3.geoCircle about d3-geo HOT 5 CLOSED

d3 avatar d3 commented on April 25, 2024
d3.geoCircle

from d3-geo.

Comments (5)

mbostock avatar mbostock commented on April 25, 2024 1

Hadn’t thought that far ahead. I forgot that it was used by d3.geoCircle. If that’s the case, probably leave it in.

from d3-geo.

mbostock avatar mbostock commented on April 25, 2024 1

Sure, a rename sounds fine.

from d3-geo.

chrisuehlinger avatar chrisuehlinger commented on April 25, 2024

So in the README scaffold you checked in, you say that we might be moving d3.geoRotation() to the d3-geo-projection package. However, it (along with the spherical projection) are required for the current implementation of d3.geoCircle(). Should I take a crack at re-implementing d3.geoCircle without them or should we just include them in d3-geo.

Also, if d3.geoRotation() is getting the boot, are the "batteries included" projections like Mercator going with it?

from d3-geo.

chrisuehlinger avatar chrisuehlinger commented on April 25, 2024

I've got a circle branch ready to go once rotation merges. However, in the README you seemed unsure whether you wanted to rename circle.origin and circle.angle to circle.center and circle.radius. Do you want me to rename them (I'm personally in favor, though I get why they were called those names originally) or do you want to think about it a bit longer?

from d3-geo.

mbostock avatar mbostock commented on April 25, 2024

Fixed by @chrisuehlinger in #21.

from d3-geo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.