d8-contrib-modules / tfa_basic Goto Github PK

The D7 module used a hook_form_alter() to modify the form elements of the TFA settings form.

I don't see a need to alter the existing form for these settings. My recommendation would be to provide TFA Basic with its own configuration form. Further investigation will be needed to confirm this assumption.

Implement tests for the TFA basic module.

This will need to be done as plugin types are finalized. Should this be broken out into a test per plugin?

Currently the module is deployed with a copy of the google authenticator source code. The standard in D8 is to include third-party code using composer. This will allow the module to quickly and easily provide updates. It will also prevent conflicts with other module that may use authenticator for other tasks.

There should be a weight option inside Tfa configuration page for "Security" menu . So that admin can configure the weight of Security menu according to his/her wish. He/She may want to keep this menu just after "Edit" menu or may want atlast. Please suggest so that i can code accordingly.

qrcode js should be in the libraries.yml file.
Currently it is defined in hook_library.

Though we are not using this currently, should we remove this altogether given it requires you to add inline js?

I tried a lot but could not find any info on how to add inline js in drupal 8.

There are several functions in the .module file that should be placed into a service. Doing this will be a better demonstration of how D8 should be done and will clean up the .module file which typically should only contain hook_ implementations.

There are several concepts in D8 that are not being utilized in the tfa_basic module.

• Dependency injection. Classes shouldn't need to use \Drupal:: in most cases.
• TBD

Implement the ability to use SMS validation for the TFA module.