Should x-default and alternate links be pushed via HTTP2? about pimcore-i18n

[solverat]

@alexej-d mhm, that's interesting. Do you have any screenshot of the rendered link?

In my tests, the webLink attribute only get's applied, if the webLink explicitly has been set.

Pimcore reference:

https://github.com/pimcore/pimcore/blob/e1408784d9d00901b19dfdded1fd6025f47bf6a4/lib/Twig/Extension/Templating/Traits/WebLinksTrait.php#L85

[alexej-d]

Check the Chrome network inspection tab – for example these are the links that are pushed on the /de route on our instance:

[solverat]

@alexej-d, thanks! Still weird, in my case, no weblink will be pushed in the setup.

I tested the x-default link for example:

pimcore-i18n/src/I18nBundle/EventListener/Frontend/HeadLinkListener.php

Line 72 in efaa274

$this->headLink->appendAlternate($this->generateHrefLink($xDefaultUrl), false, false, ['hreflang' => 'x-default']);

Still no preloaded link. If I'm adding the weblink attribute:

than I'm also see the preloaded link:

[solverat]

However, I don't think it is wrong to add this attribute, if it helps! A PR would be great!

[alexej-d]

@solverat did you set this config?

framework:
    web_link:
        enabled: true

I presume this is the reason for this behaviour.

[solverat]

@alexej-d: Yes, that's also enabled on my site.

[solverat]

Merged, thank you @alexej-d