GithubHelp home page GithubHelp logo

Comments (8)

solverat avatar solverat commented on May 28, 2024 1

@aarongerig That's a good one, thanks! It's already on my to-do list. We're only going to release that for v2, but we would accept a PR for v1 then!

from pimcore-seo.

aarongerig avatar aarongerig commented on May 28, 2024 1

@solverat Yup, that should be pretty much it! 👍

from pimcore-seo.

solverat avatar solverat commented on May 28, 2024 1

Done with #42! Thanks @aarongerig for the inputs!

from pimcore-seo.

aarongerig avatar aarongerig commented on May 28, 2024

Any input on this, so I can start with the implementation? Would be very much appreciated – thanks! 🙂

from pimcore-seo.

solverat avatar solverat commented on May 28, 2024

@aarongerig I was thinking about how to implement this and I'm wondering if there is an easier way to this.

I came up with this: We're going to extend the "HTML-Tags" tab with an additional dropdown "presets":

image


Those presets can be configured like this, so it's easy to extend them:

  -   integrator_name: html_tag
      integrator_config:
          presets:
              -
                  label: 'Robots No-Index'
                  value: '<meta name="robots" content="noindex, nofollow">'
                  icon_class: 'pimcore_icon_stop'
              -   label: 'Secret Meta-Link'
                  value: '<meta name="secret" content="secret-thing">'

Furthermore, those preset values cannot be edited:
image


Also, to assert safety here, it's possible to disable the "Add HTML Tag-Field" (and also the warning) by adding the presets_only_mode flag:

-   integrator_name: html_tag
    integrator_config:
        presets_only_mode: true
        presets:
            -
                label: 'Robots No-Index'
                value: '<meta name="robots" content="noindex, nofollow">'
                icon_class: 'pimcore_icon_stop'

Which then looks like this:
image

image


What do you think?

from pimcore-seo.

solverat avatar solverat commented on May 28, 2024

Maybe we should replace the Title "Tag:" with the Preset name.

from pimcore-seo.

aarongerig avatar aarongerig commented on May 28, 2024

@solverat Love it! Really like the approach to make it flexible with those presets, so we're not limited with adding other meta tags in the future. The presets_only_mode flag definitely makes sense IMO too!

Regarding the title "Tag:": Either "HTML Output" or the name of the preset, I'm good with both. 😊

from pimcore-seo.

solverat avatar solverat commented on May 28, 2024

@aarongerig: That's the current state:

image

If you're allowing custom tags too, it looks like this:

image

I think that's it, right?

from pimcore-seo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.