GithubHelp home page GithubHelp logo

Comments (4)

daffl avatar daffl commented on July 22, 2024

It should be null really because usually the callback context is not defined. Pre-bound methods (and arrow functions) should still have the correct context anyway.

from rubberduck.

Download avatar Download commented on July 22, 2024

It should be this, as the wrapper function will receive the same this as the original function would have. If the original function would have received null, this in the wrapper will be null. (I'm assuming that the wrapper should not interfere with the original functionality, just add to it)

If the wrapper does not pass this, then bind on the wrapped function will not work as expected.

from rubberduck.

Download avatar Download commented on July 22, 2024

Ah yes I missed that you already saved this as context. Thanks for the fix!

from rubberduck.

daffl avatar daffl commented on July 22, 2024

👍 Thanks for bringing it up. Definitely was a good fix.

from rubberduck.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.