GithubHelp home page GithubHelp logo

Comments (6)

daixiang0 avatar daixiang0 commented on September 26, 2024

Could you try latest version?

from gci.

brandon-lango avatar brandon-lango commented on September 26, 2024

Could you try latest version?

I'm using the latest version of golangci-lint, which includes gci 0.3.2. golangci/golangci-lint#2640

I'm not sure when they will update to 0.3.3, but it doesn't look like that version has fixes for these issues.

from gci.

ngehrsitz avatar ngehrsitz commented on September 26, 2024

@brandon-lango Could you please specify the exact command that you ran gci with and upload the affected files so that I can try to reproduce the issue. Only the import section is relevant you can remove everything else.

from gci.

brandon-lango avatar brandon-lango commented on September 26, 2024

Here are a few examples. It seems to fail everywhere there is an import alias or we use the zap package. I'm running gci as a part to golangci-lint, not as a standalone command. We are using all the default settings for gci.

Expected 'i', Found 'o' at pkg/mt/infra/providers/onedrive/download.go[line 9,col 4] (gci)
"go.uber.org/zap"

import (
	"encoding/json"
	"fmt"
	"io/ioutil"
	"sync"

	"go.uber.org/zap"
)

Expected '\t', Found '\n' at pkg/mt/infra/providers/externalstorage/goroutines.go[line 5,col 1] (gci)

import (
	"github.com/hashicorp/go-multierror"

	mtCommand "github.com/langomobiledev/lango/pkg/mt/app/command"
	"github.com/langomobiledev/lango/pkg/mt/domain/filestorage"
)

Expected '"', Found 'l' at pkg/auth/infra/providers/cognito/register.go[line 11,col 2] (gci)
log "github.com/sirupsen/logrus"

import (
	"context"
	"errors"
	"fmt"

	"github.com/aws/aws-sdk-go-v2/aws"
	cognito "github.com/aws/aws-sdk-go-v2/service/cognitoidentityprovider"
	"github.com/aws/aws-sdk-go-v2/service/cognitoidentityprovider/types"
	log "github.com/sirupsen/logrus"

	"github.com/langomobiledev/lango/pkg/auth/domain/users"
)

from gci.

daixiang0 avatar daixiang0 commented on September 26, 2024

Please add prefix to test.

from gci.

NicklasWallgren avatar NicklasWallgren commented on September 26, 2024

I've got this issue as well with golangci-lint v1.46.2

infrastructure/database/database.go:7:2: Expected '"', Found 'g' at infrastructure/database/database.go[line 7,col 2] (gci)
        gormTrace "gopkg.in/DataDog/dd-trace-go.v1/contrib/gorm.io/gorm.v1"
        ^

from gci.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.