Running error: gci: failed to diff: exec: \"diff\": executable file not found in $PATH about gci

[SVilgelm]

Instead of this: https://github.com/daixiang0/gci/blob/master/pkg/gci/gci.go#L178-L198

you can do like this:

	out := bytes.Buffer{}
	_, err = out.WriteString(fmt.Sprintf("--- %[1]s\n+++ %[1]s\n", f))
	if err != nil {
		return nil, fmt.Errorf("error while running gofumpt: %w", err)
	}
	err = differ.Diff(&out, bytes.NewReader(b1), bytes.NewReader(b2))
	if err != nil {
		return nil, fmt.Errorf("error while running gofumpt: %w", err)
	}
	return out.Bytes()

[SVilgelm]

and least it will be faster than using a subcommand

[daixiang0]

Goimports still call diff, need to dig deeper.

[SVilgelm]

I would prefer to turn off goimports than gci :)

[daixiang0]

Thanks!

While I do not want any extra pkg here, so i would update gci.Run and the way to call in golang-ci.

[SVilgelm]

thank you for the quick fix!!!!