GithubHelp home page GithubHelp logo

Comments (5)

dalemanthei avatar dalemanthei commented on August 16, 2024

@jrstrayhorn Opening an issue is fine with me.

I think the crux of the problem is an undocumented dependency between the import paths for components and the folder structure in the project.

Here's the dep-graph for the master branch:

image

Here's a dep-graph for the working-dep-graph branch I just created:

image

Getting the dep-graph to work is a global change from @dmv/demo/ to @dmv/. There might be a way to structure the folders in the project to something like ../libs/demo/button etc that could make this work. In our production repo our path was @vdlx/vdl-angular/... I think the hyphenated part of the path vdl-angular gave us more troubles since some part of the tooling seemed to want ../libs/vdl/angular/...

We just didn't have the luxury of resources to see if we could go down that path. However, now that I have this repo and there's only a single, non-hyphenated element between the npm space and component it could be made to work.

I do have hopes that the nx team's work on this will eventually solve for this. Or at the very least make the path to folder mapping explicit that we can make it work for us.

Hope this helps!

from nx-ng-packagr-demo.

dalemanthei avatar dalemanthei commented on August 16, 2024

@jrstrayhorn Ok, the above got me to thinking... so I made another branch to insert a demo folder and it got the dep-graph working another way but not quite complete.

The branch is use-demo-folder

Here's the dep-graph for that branch:

image

It's still disconnected between the apps and the components but within the components the graph is ok.

from nx-ng-packagr-demo.

jrstrayhorn avatar jrstrayhorn commented on August 16, 2024

@dalemanthei - wow! thanks so much for taking a look at this and responding..

ah ha!! so adding a root /demo folder under /libs to match tsconfig paths got the dep-graph working? "going to try this in our project here shortly"

I believe this is the scenario we'd want so we can have at least some sort of dep-graph that can show how all the components/libs are connected to one another - this can help with ensuring proper ordering of lib building.

One more questions - do you do any sort of automating to make sure the libs/components are building in the right order? I'm thinking manually may be the only way but wanted to pick your brain on it.

Thanks again!!

from nx-ng-packagr-demo.

dalemanthei avatar dalemanthei commented on August 16, 2024

Reference the README for the building the library. It probably only works for master but the package.json scripts have the manual sequencing.

from nx-ng-packagr-demo.

jrstrayhorn avatar jrstrayhorn commented on August 16, 2024

That makes sense!! Thanks so much!! will close this...

from nx-ng-packagr-demo.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.