Comments (8)
@nick-iCars I absolutely will! It shouldn't be too difficult to implement.
Thanks! 😄
from notificationbanner.
Hi @nick-iCars! 😄
You aren't the first person to propose this functionality so I am going to go ahead and add it to the next release milestone!
Thanks!
from notificationbanner.
😀
from notificationbanner.
LMK if I can contribute on anything. Haven't really looked at the code tbh.
from notificationbanner.
Included in v1.3.0 release! 🎉
from notificationbanner.
Nice work, dude! Thanks again!
from notificationbanner.
Was just looking to update my project using the new features and I'm running into an issue, I was going to just submit a pull request but I'm not 100% sure what is going on, figured I'd ask. So I ran pod update and pod install it looks like it sees the update and installs it (pod install logs: 'Using NotificationBannerSwift (1.3.0)'), however when I try and use the show(from:) method it does not appear to be included. I went in to inspect what was going on and I also saw an error on line 73 of NotificationBanner.swift:
titleLabel!.type = .left
NotificationBanner.swift:73:29: Type 'MarqueeLabel.MarqueeType' has no member 'left'
I looked at the repo and files on github and I don't see this on the file on master branch (it uses the correct call of titleLabel!.type = .leftRight, but maybe im not understanding something. Any idea what is going on here? Is there some different repo for the cocoapod im not seeing?
from notificationbanner.
@nick-iCars Let's take this conversation over to #23
from notificationbanner.
Related Issues (20)
- Multiple notifications lead to strange behaviour
- NotificationBanner + Carthage + xcode 13 does not work
- The banner disappears behind the dynamic island for iPhone 14 Pro HOT 4
- Banner style extension
- StatusBarNotificationBanner onTap not working
- Main Thread crash HOT 3
- iPhone Dynamic Island HOT 1
- NotificationBannerQueue needs to depend on a protocol (Liskov principle)
- SwiftUI HOT 1
- The position of the banner on the screen when changing orientation HOT 2
- Why disallow background color for custom views? HOT 1
- App crashes on nil bannerPosition when using `.applyStyling` HOT 1
- The banner has the wrong width when it is displayed on the primary view
- closure #2 in BaseNotificationBanner.dismiss(forced:) NSInternalInconsistencyException - Must have a keyboard layer tracked.
- could not find module 'NotificationBannerSwift' for target 'x86_64-apple-ios-simulator' HOT 1
- customize the height
- Issue regarding position When 2 Banner whowing same time HOT 1
- sideViewSize no longer available
- CarPlay blocks the NotificationBanner
- How can I add layer border? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from notificationbanner.