GithubHelp home page GithubHelp logo

Comments (8)

Daltron avatar Daltron commented on May 13, 2024 1

@nick-iCars I absolutely will! It shouldn't be too difficult to implement.
Thanks! 😄

from notificationbanner.

Daltron avatar Daltron commented on May 13, 2024

Hi @nick-iCars! 😄

You aren't the first person to propose this functionality so I am going to go ahead and add it to the next release milestone!

Thanks!

from notificationbanner.

nick-iCars avatar nick-iCars commented on May 13, 2024

😀

from notificationbanner.

nick-iCars avatar nick-iCars commented on May 13, 2024

LMK if I can contribute on anything. Haven't really looked at the code tbh.

from notificationbanner.

Daltron avatar Daltron commented on May 13, 2024

Included in v1.3.0 release! 🎉

from notificationbanner.

nick-iCars avatar nick-iCars commented on May 13, 2024

Nice work, dude! Thanks again!

from notificationbanner.

nick-iCars avatar nick-iCars commented on May 13, 2024

Was just looking to update my project using the new features and I'm running into an issue, I was going to just submit a pull request but I'm not 100% sure what is going on, figured I'd ask. So I ran pod update and pod install it looks like it sees the update and installs it (pod install logs: 'Using NotificationBannerSwift (1.3.0)'), however when I try and use the show(from:) method it does not appear to be included. I went in to inspect what was going on and I also saw an error on line 73 of NotificationBanner.swift:
titleLabel!.type = .left

NotificationBanner.swift:73:29: Type 'MarqueeLabel.MarqueeType' has no member 'left'

I looked at the repo and files on github and I don't see this on the file on master branch (it uses the correct call of titleLabel!.type = .leftRight, but maybe im not understanding something. Any idea what is going on here? Is there some different repo for the cocoapod im not seeing?

from notificationbanner.

Daltron avatar Daltron commented on May 13, 2024

@nick-iCars Let's take this conversation over to #23

from notificationbanner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.