GithubHelp home page GithubHelp logo

Comments (4)

josetaykus avatar josetaykus commented on June 29, 2024 2

Flicks is related to this lines;

appWindow?.windowLevel = UIWindow.Level.normal

I have commented everything related to this window level and now is all good, but i dont know if this will have side effects.

from notificationbanner.

scottgriv avatar scottgriv commented on June 29, 2024 1

Flicks is related to this lines;

appWindow?.windowLevel = UIWindow.Level.normal

I have commented everything related to this window level and now is all good, but i dont know if this will have side effects.

I commented it out in all three places in the BaseNotificationBanner.swift class and everything seems to be working well now, thanks @nigeshvenu.

I didn't put in a PR because I'm not sure if this affects anything for other use cases other than how I'm using it on the top level.

For others experiencing this issue:

Lines 401, 406:

        if let parentViewController = parentViewController, parentViewController.view != nil {
            parentViewController.view.addSubview(self)
            if statusBarShouldBeShown() {
                //appWindow?.windowLevel = UIWindow.Level.normal
            }
        } else {
            appWindow?.addSubview(self)
            if statusBarShouldBeShown() && !(parentViewController == nil && bannerPosition == .top) {
                //appWindow?.windowLevel = UIWindow.Level.normal
            } else {
                appWindow?.windowLevel = UIWindow.Level.statusBar + 1
            }
        }

Line 610:

        self.bannerQueue.showNext(callback: { (isEmpty) in
            if isEmpty || self.statusBarShouldBeShown() {
                //self.appWindow?.windowLevel = UIWindow.Level.normal
            }
        })

from notificationbanner.

josetaykus avatar josetaykus commented on June 29, 2024

Same happens to me :(

But only if you show the banner on top and not always, if you show at bottom nothing happens :|

from notificationbanner.

nigeshvenu avatar nigeshvenu commented on June 29, 2024

It seems that adjusting the window level by setting it to UIWindow.Level.statusBar + 1 while showing the banner and then resetting it to UIWindow.Level.normal upon dismissal is causing the issue. I have commented out these lines for now to maintain the default window level. Hope an update will available in the near future.

from notificationbanner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.