GithubHelp home page GithubHelp logo

Comments (6)

damiengarbarino avatar damiengarbarino commented on June 9, 2024

Hello,

I traced the code and found a NPE which is not the source of the issue.

The problem is that the store update function is called when item #2 is updated with a previous index of -1 which means that this is a new data item.

I suspect that this is a bug of the DataStore class because if you replace the DataStore by a MemoryStore the call is done with a previous index of 1 which is correct. And so you have a correct rendering.

from dojo-calendar.

damiengarbarino avatar damiengarbarino commented on June 9, 2024

I registered http://trac.dojotoolkit.org/ticket/14986 on this issue.

from dojo-calendar.

cjolif avatar cjolif commented on June 9, 2024

As this is a dojo/store bug let's close the calendar issue and wait for the dojo/store bug to be fixed. Please re-open if any indication the pb actually comes from calendar.

from dojo-calendar.

cjolif avatar cjolif commented on June 9, 2024

It seems to me a workaround might be to have

calendar_dataStore.queryEngine = SimpleQueryEngine;

Indeed Observable seems to not pass indexes if there is no query engine... Maybe this can help you?

from dojo-calendar.

ezp-matt avatar ezp-matt commented on June 9, 2024

I wonder if this fails with the JsonRest store as well, since it doesn't define a queryEngine either..? In which case maybe it's more of an issue with Observable, and not just DataStore specifically. It seems like Observable should be just using the store's query() function (which is defined in every store), rather than looking for a queryEngine in the store, which may or may not exist. Memory's query() just uses the queryEngine anyhow.

I'll play around with it and see if I can figure out a fix. :)

from dojo-calendar.

cjolif avatar cjolif commented on June 9, 2024

Yes the "issue" is more in Observable than DataStore. If you can figure out an Observable fix please provide it on the trac ticket. Thanks a lot!

from dojo-calendar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.