GithubHelp home page GithubHelp logo

Comments (8)

coderdave avatar coderdave commented on June 11, 2024

I'm also having the same issue ONLY on my iPhone 6s. As @deanmcpherson was saying, it works fine on all of my other devices and also the 6s simulator.

I also thought it has something to do with 3d touch, but I disabled it on my phone and was still having the issue. (However, I'm not sure if disabling it in settings is the same as not having that feature at all on a phone)

I haven't tested if it on an iPhone 6s plus.

from react-native-swipeout.

deanmcpherson avatar deanmcpherson commented on June 11, 2024

@coderdave It is the same on the 6s and 6s plus, I'll see if I can debug it today.

from react-native-swipeout.

deanmcpherson avatar deanmcpherson commented on June 11, 2024

As per facebook/react-native#3082, this was resolved for me by checking if dy/ dx is not 0 before granting a PanResponder in onMoveShouldSetPanResponder.

from react-native-swipeout.

coderdave avatar coderdave commented on June 11, 2024

@deanmcpherson So what's the workaround code to fix it until FB fixes it internally?

from react-native-swipeout.

por avatar por commented on June 11, 2024

@deanmcpherson I would also like to know what your current workaround is. Can you share it?

edit: figured it out. I interpreted the / in dy / dx a bit too literal. Here’s my workaround:

_handleMoveShouldSetPanResponder: function(e: Object, gestureState: Object): boolean {
  if (gestureState.dx === 0 || gestureState.dy === 0) {
    return false;
  }
  return true;
}

from react-native-swipeout.

deanmcpherson avatar deanmcpherson commented on June 11, 2024

hey @por, @coderdave sorry for the slow reply, @por's solution is the same as mine.

from react-native-swipeout.

coderdave avatar coderdave commented on June 11, 2024

Thanks. Ok, so we're basically having to override the _handleMoveShouldSetPanResponder function in swipeout's code.

Would it make sense to update react-native-swipeout and release a new version? It seems like it's on react's radar but hasn't been fixed yet.

from react-native-swipeout.

techmentormaria avatar techmentormaria commented on June 11, 2024

fyi created a pull request for future reference
#47

from react-native-swipeout.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.