Comments (15)
OK, https://travis-ci.org/danger/danger-js/jobs/196765527#L479
from danger-js.
Yep, it's all of that on the bottom
from danger-js.
In Ruby I tend to do a PR with the changes then self-merge, I'll start doing that here too:
danger/danger#705
danger/danger#690
danger/danger#676
from danger-js.
Any reason not to have Travis do the publishing of tagged commits to NPM? It's super-easy!
I've started setting up my repos so that running npm version
will kick off tests, update the changelog, push the commit, and then travis publishes. I love it.
from danger-js.
I'm into this, yeah :D
For me npm version
just shows some metadata?
from danger-js.
npm version <new-version>
where new-version
is one of major
/minor
/patch
to auto-increment that field, or some arbitrary version like 1.2.3-rc6
to set it to that specific value.
It'll run any preversion
/version
/postversion
hooks in package.json scripts
, change the version
field in package.json to match & if run in a git repo will submit a tagged commit w/ the package.json change.
from danger-js.
This sounds like a great idea, @tivac.
So we should be able to use something like this in .travis.yml
:
deploy:
...
on:
tags: true
And when npm version
creates a new tag and we push to GitHub, it will deploy that new version to NPM, right?
I'm wondering how we will update the changelog, and I poked into a repo of yours to see if I could find an example, @tivac. Looks like we could use the @studio/changes
package and perhaps similar pre/post/version scripts as seen in your mithrill-codemods repo as a starting point (let me know if you have other suggestions too).
from danger-js.
I'm wary of automating the creation of CHANGELOG entries
I consider the CHANGELOG to basically be the main way people see update information, so it should be written with users in mind, whereas commits and PRs tend to use "I work on danger" specific terminology. Which is why it can be one of the only places I'll be pedantic on a PR.
Happy to have it basically take new version from package.json or wherever and prepend it below // Add your own contribution below
though? This is what I do basically anyway
from danger-js.
@macklinu yeah, since npm version
creates a tagged commit when you push to GH Travis will see it, trigger two builds (one for the branch, one for the tag) and the build for the tagged commit will use encrypted npm auth token to push the package to npm.
@orta that's totally fair. I use @studio/changes
because otherwise I have terrible habits and don't do a changelog at all. I use validate-commit-msg
as a precommit hook (via husky
) to ensure that my commits are formatted nicely and then usually just tidy those up for the changelog entries.
Not saying you have to use those patterns, but I find them helpful to curtail some of my bad habits!
from danger-js.
Happy to have it basically take new version from package.json or wherever and prepend it below
// Add your own contribution below
though? This is what I do basically anyway
This sounds good, and I think @studio/changes
will help us enforce this if we want to do it manually:
Or we can find a way to automate that behavior too.
from danger-js.
I don't do much tweaking of the generated CHANGES.md
file, but you could certainly use the commit messages it auto-populates as a jumping-off point to write more detailed changelog entries! It'd just be like a nice little inline reminder of what was actually in the release at that point 😄
from danger-js.
I've set up travis so that tags can deploy npm version patch
looks like`
from danger-js.
interesting, not seeing it working
from danger-js.
I'm tempted to move entirely to semantic-release but I do like the ability to ship a few PRs together, allowing for larger bits of work
from danger-js.
I decided against semantic-release - the whole reason that the Moya contributors policy works is because we can take the time to fix before release, instead of shipping every PR. Happy to call this done.
from danger-js.
Related Issues (20)
- Maybe there is better way to do it?
- Perf, people check huge amounts of files and that can hit the GH API limits HOT 1
- Feature Request: Per commit modified_files, JSONDiffForFile, fileMatch HOT 1
- [BUG] jsonwebtoken needs to be updated HOT 1
- [BUG] Duplicate report coments on GitHub actions if we use a custom CI bot token HOT 9
- Request to Release 11.2.2
- [BUG] Inline comments often don't show up, or show incorrectly with GitLab self-hosted HOT 5
- RFE: Add gitlab to project tags HOT 1
- [BUG] Changelog not updated on website
- There are a lot of outdated dependencies in this project, it could benefit from dependency scanning HOT 3
- [BUG] Request failed [403]: https://api.github.com/user HOT 3
- [BUG] danger.github.pr is undefined when in a mergequeue HOT 3
- [BUG] GITHUB_URL is magic in Github-hosted-runners, but shouldn't be used for API Calls HOT 5
- Danger is not commenting on PR HOT 2
- [BUG] Danger Ignore not working on Gitlab - Tried different formats HOT 6
- [BUG] Inline comments deleted in GitLab pipeline HOT 6
- [BUG] danger.github.reviews only providing the first 30 reviews HOT 7
- [BUG] --removePreviousComments overrides resolved threads on Gitlab HOT 7
- [DEPS] Move from @gitbeaker/node to @gitbeaker/rest HOT 3
- [BUG] Danger taking comments as modified files HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from danger-js.