Plugins don't resolve about peril

[orta]

Seems to be there

 ~/d/p/d/peril   master $  heroku run 'ls node_modules' --app peril-staging      5.1s  Sat 12 Aug 15:53:23 2017
Running ls node_modules on ⬢ peril-staging... up, run.8629 (Free)
@types							 fb-watchman		    nwmatcher
abab							 figures		    oauth-sign
abbrev							 filename-regex		    object-assign
accepts							 fileset		    object.omit
acorn							 fill-range		    object.pick
acorn-globals						 filled-array		    on-finished
agent-base						 finalhandler		    once
ajv							 find-up		    onetime
align-text						 follow-redirects	    optimist
amdefine						 for-in			    optionator
ansi-align						 for-own		    os-homedir
ansi-escapes						 forever-agent		    os-locale
ansi-regex						 form-data		    os-shim
ansi-styles						 forwarded		    os-tmpdir
any-promise						 fresh			    osenv
anymatch						 fs-extra		    output-file-sync
ap							 fs-readdir-recursive	    p-finally
append-transform					 fs.realpath		    p-limit
archy							 function-bind		    p-locate
argparse						 generic-pool		    p-map
arr-diff						 get-caller-file	    package-json
arr-flatten						 get-stdin		    packet-reader
array-equal						 get-stream		    parse-diff
array-flatten						 getpass		    parse-glob
array-union						 github			    parse-json
array-uniq						 glob			    parse-link-header
array-unique						 glob-base		    parse5
arrify							 glob-parent		    parseurl
asn1							 globals		    path-exists
assert-plus						 globby			    path-is-absolute
async							 glossy			    path-key
async-each						 got			    path-parse
asynckit						 graceful-fs		    path-to-regexp
aws-sign2						 graceful-readlink	    path-type
aws4							 growly			    performance-now
babel-cli						 handlebars		    pg
babel-code-frame					 har-schema		    pg-connection-string
babel-core						 har-validator		    pg-minify
babel-generator						 has			    pg-pool
babel-helper-builder-binary-assignment-operator-visitor  has-ansi		    pg-promise
babel-helper-call-delegate				 has-flag		    pg-types
babel-helper-define-map					 has-unicode		    pgpass
babel-helper-explode-assignable-expression		 hawk			    pify
babel-helper-function-name				 hoek			    pinkie
babel-helper-get-function-arity				 home-or-tmp		    pinkie-promise
babel-helper-hoist-variables				 hosted-git-info	    pkg-dir
babel-helper-optimise-call-expression			 html-encoding-sniffer	    popsicle
babel-helper-regex					 htmlparser2		    popsicle-proxy-agent
babel-helper-remap-async-to-generator			 http-errors		    popsicle-retry
babel-helper-replace-supers				 http-proxy-agent	    popsicle-rewrite
babel-helpers						 http-signature		    popsicle-status
babel-jest						 https-proxy-agent	    postgres-array
babel-messages						 hunspell-spellchecker	    postgres-bytea
babel-plugin-check-es2015-constants			 ice-cap		    postgres-date
babel-plugin-istanbul					 iconv-lite		    postgres-interval
babel-plugin-jest-hoist					 imurmurhash		    prelude-ls
babel-plugin-syntax-async-functions			 inflight		    prepend-http
babel-plugin-syntax-async-generators			 inherits		    preserve
babel-plugin-syntax-exponentiation-operator		 ini			    pretty-format
babel-plugin-syntax-flow				 inquirer		    private
babel-plugin-syntax-object-rest-spread			 invariant		    process-nextick-args
babel-plugin-syntax-trailing-function-commas		 invert-kv		    promise-finally
babel-plugin-transform-async-generator-functions	 ipaddr.js		    proxy-addr
babel-plugin-transform-async-to-generator		 is-absolute		    prr
babel-plugin-transform-es2015-arrow-functions		 is-arrayish		    pseudomap
babel-plugin-transform-es2015-block-scoped-functions	 is-binary-path		    punycode
babel-plugin-transform-es2015-block-scoping		 is-buffer		    qs
babel-plugin-transform-es2015-classes			 is-builtin-module	    randomatic
babel-plugin-transform-es2015-computed-properties	 is-ci			    range-parser
babel-plugin-transform-es2015-destructuring		 is-dotfile		    raw-body
babel-plugin-transform-es2015-duplicate-keys		 is-equal-shallow	    rc
babel-plugin-transform-es2015-for-of			 is-extendable		    read-all-stream
babel-plugin-transform-es2015-function-name		 is-extglob		    read-pkg
babel-plugin-transform-es2015-literals			 is-finite		    read-pkg-up
babel-plugin-transform-es2015-modules-amd		 is-fullwidth-code-point    readable-stream
babel-plugin-transform-es2015-modules-commonjs		 is-glob		    readdirp
babel-plugin-transform-es2015-modules-systemjs		 is-npm			    regenerate
babel-plugin-transform-es2015-modules-umd		 is-number		    regenerator-runtime
babel-plugin-transform-es2015-object-super		 is-obj			    regenerator-transform
babel-plugin-transform-es2015-parameters		 is-plain-obj		    regex-cache
babel-plugin-transform-es2015-shorthand-properties	 is-posix-bracket	    regexpu-core
babel-plugin-transform-es2015-spread			 is-primitive		    registry-auth-token
babel-plugin-transform-es2015-sticky-regex		 is-promise		    registry-url
babel-plugin-transform-es2015-template-literals		 is-redirect		    regjsgen
babel-plugin-transform-es2015-typeof-symbol		 is-relative		    regjsparser
babel-plugin-transform-es2015-unicode-regex		 is-retry-allowed	    repeat-element
babel-plugin-transform-exponentiation-operator		 is-stream		    repeat-string
babel-plugin-transform-flow-strip-types			 is-typedarray		    repeating
babel-plugin-transform-object-rest-spread		 is-unc-path		    request
babel-plugin-transform-regenerator			 is-utf8		    require-directory
babel-plugin-transform-strict-mode			 is-windows		    require-main-filename
babel-polyfill						 isarray		    resolve
babel-preset-es2015					 isemail		    restore-cursor
babel-preset-jest					 isexe			    rfc6902
babel-preset-stage-3					 isobject		    right-align
babel-register						 isstream		    rimraf
babel-runtime						 istanbul-api		    run-async
babel-template						 istanbul-lib-coverage	    rx
babel-traverse						 istanbul-lib-hook	    safe-buffer
babel-types						 istanbul-lib-instrument    sane
babylon							 istanbul-lib-report	    sax
balanced-match						 istanbul-lib-source-maps   semver
base64url						 istanbul-reports	    semver-diff
bcrypt-pbkdf						 jest			    send
binary-extensions					 jest-changed-files	    serve-static
bluebird						 jest-cli		    set-blocking
body-parser						 jest-config		    set-immediate-shim
boolbase						 jest-diff		    setprototypeof
boom							 jest-docblock		    shebang-command
boxen							 jest-environment-jsdom     shebang-regex
brace-expansion						 jest-environment-node	    shellwords
braces							 jest-haste-map		    signal-exit
browser-resolve						 jest-jasmine2		    sinon-as-promised
bser							 jest-matcher-utils	    slash
buffer-equal-constant-time				 jest-matchers		    slice-ansi
buffer-shims						 jest-message-util	    slide
buffer-writer						 jest-mock		    sntp
builtin-modules						 jest-regex-util	    sort-keys
bytes							 jest-resolve		    source-map
callsites						 jest-resolve-dependencies  source-map-support
camelcase						 jest-runtime		    spawn-sync
capture-stack-trace					 jest-snapshot		    spdx-correct
caseless						 jest-util		    spdx-expression-parse
center-align						 jest-validate		    spdx-license-ids
chalk							 jodid25519		    spex
cheerio							 joi			    split
chokidar						 js-tokens		    sprintf-js
ci-info							 js-yaml		    sshpk
cli-boxes						 jsbn			    stack-trace
cli-cursor						 jsdom			    statuses
cli-truncate						 jsesc			    stream-consume
cli-width						 jsome			    string-length
cliui							 json-schema		    string-template
clone							 json-stable-stringify	    string-width
co							 json-stringify-safe	    string_decoder
code-point-at						 json2ts		    stringstream
color-convert						 json5			    strip-ansi
color-logger						 jsonfile		    strip-bom
color-name						 jsonify		    strip-eof
colors							 jsonpointer		    strip-json-comments
columnify						 jsonwebtoken		    supports-color
combined-stream						 jspm-config		    symbol-tree
commander						 jsprim			    taffydb
concat-map						 jwa			    test-exclude
concat-stream						 jws			    thenify
config							 kind-of		    throat
configstore						 klaw			    through
content-disposition					 latest-version		    timed-out
content-type						 lazy-cache		    tmp
content-type-parser					 lazy-req		    tmpl
convert-source-map					 lcid			    to-fast-properties
cookie							 leven			    topo
cookie-signature					 levn			    touch
core-js							 listify		    tough-cookie
core-util-is						 load-json-file		    tr46
create-error-class					 locate-path		    trim-right
create-thenable						 lockfile		    ts-jest
cross-spawn						 lodash			    ts-node
cryptiles						 lodash._objecttypes	    tsconfig
crypto-random-string					 lodash.assign		    tslib
css-select						 lodash.assignin	    tslint
css-what						 lodash.bind		    tsutils
cssom							 lodash.defaults	    tunnel-agent
cssstyle						 lodash.filter		    tweetnacl
cycle							 lodash.find		    type-check
danger							 lodash.flatten		    type-is
danger-plugin-spellcheck				 lodash.foreach		    typedarray
danger-plugin-yarn					 lodash.includes	    typescript
dashdash						 lodash.isobject	    typings
date-fns						 lodash.keys		    typings-core
debug							 lodash.map		    uglify-js
decamelize						 lodash.merge		    uglify-to-browserify
deep-extend						 lodash.once		    unc-path-regex
deep-is							 lodash.pick		    underscore
default-require-extensions				 lodash.reduce		    unique-concat
defaults						 lodash.reject		    unique-string
delayed-stream						 lodash.some		    universalify
depd							 log-update		    unpipe
destroy							 longest		    unzip-response
detect-indent						 loose-envify		    update-notifier
diff							 lowercase-keys		    url-parse-lax
dom-serializer						 lru-cache		    user-home
domelementtype						 make-error		    util-deprecate
domhandler						 make-error-cause	    utils-merge
domutils						 makeerror		    uuid
dot-prop						 manakin		    v8flags
dotenv							 markdown-spellcheck	    validate-npm-package-license
duplexer2						 marked			    vary
ecc-jsbn						 media-typer		    verror
ecdsa-sig-formatter					 mem			    vm2
ee-first						 merge			    voca
ejs							 merge-descriptors	    walker
elegant-spinner						 methods		    watch
encodeurl						 micromatch		    wcwidth
encoding						 mime			    webidl-conversions
entities						 mime-db		    whatwg-encoding
errno							 mime-types		    whatwg-url
error-ex						 mimic-fn		    whatwg-url-compat
escape-html						 minimatch		    which
escape-string-regexp					 minimist		    which-module
escodegen						 mkdirp			    widest-line
esdoc							 moment			    window-size
esprima							 ms			    winston
estraverse						 mute-stream		    winston-papertrail
esutils							 native-promise-only	    wordwrap
etag							 natural-compare	    worker-farm
exec-sh							 negotiator		    wrap-ansi
execa							 netrc			    wrappy
exit-hook						 node-fetch		    write-file-atomic
expand-brackets						 node-int64		    write-file-promise
expand-range						 node-notifier		    xdg-basedir
express							 node-pg-migrate	    xml-name-validator
express-x-hub						 node-status-codes	    xtend
extend							 nopt			    y18n
external-editor						 normalize-package-data     yallist
extglob							 normalize-path		    yargs
extsprintf						 npm-run-path		    yargs-parser
eyes							 nth-check		    yn
fast-levenshtein					 number-is-nan		    zip-object

[orta]

The first passes, the second doesn't.

  it("allows external modules", async () => {
    const platform = fixturedGitHub()
    const executor = executorForInstallation(platform)
    const results = await runDangerAgainstFile(`${dangerfilesFixtures}/dangerfile_import_module.ts`, executor)
    expect(results.markdowns).toEqual([":tada:"])
  })

  it("allows external modules when in the tmp random folder", async () => {
    const platform = fixturedGitHub()
    const executor = executorForInstallation(platform)

    const localDangerfile = resolve(tmpdir(), "node_module_dangerfile.ts")
    const contents = readFileSync(`${dangerfilesFixtures}/dangerfile_import_module.ts`, "utf8")
    writeFileSync(localDangerfile, contents, { encoding: "utf8" })

    const results = await runDangerAgainstFile(localDangerfile, executor)
    expect(results.markdowns).toEqual([":tada:"])
  })

[orta]

this ^ may only work because there's one file. Once I got this working by using in-memory Dangerfiles, I got PerilTest/sandbox#18

Error Error

Cannot find module './string-index-context'

Error: Cannot find module './string-index-context'
    at Function.Module._resolveFilename (module.js:470:15)
    at Function.Module._load (module.js:418:25)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/app/node_modules/danger-plugin-spellcheck/dist/index.js:12:32)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)

[orta]

This was a bad build of danger-plugin-spellcheck

[orta]

And this works 🎉