daniel-lewis-ab / litegraph.js Goto Github PK

It doing that thing too.

I've tried to replace this file: https://github.com/comfyanonymous/ComfyUI/blob/master/web/lib/litegraph.core.js
with this file: https://github.com/daniel-lewis-ab/litegraph.js/blob/master/build/litegraph.core.js

Though the filename is the same, it doesn't work.

What is the correct procedure to apply the current version LG to ComfyUI?

If you:

1. go to multiview
2. leave it
3. go to subgraph
4. enter a subgraph (it will incorrectly estimate Subgraphout position)
5. click play (it will now break and not draw front canvas)

Enter subgraph like this:

Change to other graph like this:

Note, that AudioSources are loading, it's just not redrawing.

Hi, wanted to ask if you are interested in publishing this forked library in its own NPM package? I forked lightgraph myself, mainly to have up-to-date NPM packages and also implemented a release-it flow to simplify building and publishing the package.

Have a look at the README and package.json.

Hi guys,

I saw that @daniel-lewis-ab is working on the reversion and @atlasan is working on forwardcompatible. And I've sumitted a PR to the master. Is master the branch I should PR to? Did I do it right? Or, should I join @atlasan to fix things on forwardcompatible?

I need some suggestion. Thanks!

https://github.com/huchenlei/ComfyUI_frontend

This project might provide some insights of how to improve ComfyUI's frontend.

./scripts/: rewritten as TypeScript.
./lib/ and ./extensions/: still stay the same for now.

It doing that thing

A number of dialogs (such as the node search box or the widget set popup) set up event listeners to close on mouse leave. As sMethod is mouse by default, the prior implementation would handle mouse leave events with the default case, but an added break results in no warning or registration event being performed.

If the user drag the end of the link from the input slot of the next node out (I usually remove links this way), the behavior is different from the original repo.

Original LiteGraph.js:

Here:

Starting huchenlei/ComfyUI_frontend#15, the ts comfyui frontend can add npm package dependency very easily. Maybe we should consider publish this repo to npm and avoid copy/paste of files.

Found a bug, currently too tired to think in quaternions and what it needs.

When I try to do npm run build, it fails to find uglifyjs. The error message is attached below:

PS C:\ComfyUI\litegraph\litegraph.js-daniel> npm run build

> @mr_pebble/[email protected] build
> python3 build.py

Processing ./src/litegraph.js Traceback (most recent call last):
  File "C:\ComfyUI\litegraph\litegraph.js-daniel\build.py", line 170, in <module>
    pack_js_files(js_files_list["js_files"], js_files_list["output_filename"])
  File "C:\ComfyUI\litegraph\litegraph.js-daniel\build.py", line 102, in pack_js_files
    minified_js = subprocess.run(["uglifyjs", js_file, "-c"], stdout=subprocess.PIPE, text=True)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\learn\AppData\Local\Programs\Python\Python312\Lib\subprocess.py", line 548, in run
    with Popen(*popenargs, **kwargs) as process:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\learn\AppData\Local\Programs\Python\Python312\Lib\subprocess.py", line 1026, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "C:\Users\learn\AppData\Local\Programs\Python\Python312\Lib\subprocess.py", line 1538, in _execute_child
    hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [WinError 2] The system cannot find the file specified

I found explanation that, when use uglifyjs command in package.json's scripts section, it'll automatically search ./node_modules/.bin/ for the executables. However, when we use python file build.py and refer uglifyjs in it, there's no mechanism to include the ./node_modules/.bin/. I guess you didn't see this problem is because you globally installed uglifyjs, and that was used in your npm run build.

And the extension .cmd is also needed for windows, so i think we should add some code for people who are building this on Windows.

I'll do a quick PR to fix this. I am familiar with Python. :)

I have been tracking an issue with this where drag/scrolling is annoying on Mac, once I have the solution I'll ask and possibly share it into LG and ComfyUI.