daniel-olao / nasa-client Goto Github PK

If I have an error on my signup form (like an invalid phone number).

I briefly see an error icon, but no message is displayed, and the form resets and clears all my data.

Ideally the error message would display and my data would not be erased so I could correct the error and re-submit

The copy "You are not subscribed to nasa APOD" should be more verbose.

e.g.
You are currently subscribed. You will get a text with Nasa's Astronomy Picture of the Day every day at {time}

You are currently unsubscribed. Subscribe below to get a text with Nasa's Astronomy Picture of the Day every day at {time}

re-Password is not very user-friendly. Change the label to "Reenter password"

I can submit forms with empty data, or invalid emails and phone numbers.

You should prevent users from submitting errors that we know the server will not accept by validating fields on the client and preventing submit

e.g. check for that fields are not empty, for valid email, phone number, and matching passwords

I suggest using a third-party library like https://validatejs.org/

On both the login and signup screens, add a short line to explain to people what they are signing up for

e.g.
"Get Nasa's Astronomy Picture of the day texted to your phone every day"