Comments (5)
Thanks Daniel. I've been playing around with:
title: TextAppearance.MaterialComponents.Headline6
subtitle: TextAppearance.MaterialComponents.Subtitle2
but the title looks very big to me, even though Headline6 is supposed to be the smallest. What do you think?
As a workaround I add android:textSize="16sp"
(for the title) to make it look nicer, but I'm wary of using non-standard metrics.
Also, should the text in title_item and action_item look the same? If so, should that part be extracted into its own layout xml and then "included" in the two different existing layouts.
from material-about-library.
I just realised that, anyway, we should be using ?attr/ rather than the style resources directly. And it looks better because we can use the proper text appearance attrs for lists (and no need to tweak the text size):
title: ?android:attr/textAppearanceListItem
subtitle: ?android:attr/textAppearanceListItemSecondary (and personally I prefer to add android:textColor="?android:attr/textColorSecondary")
card title: ?attr/textAppearanceHeadline6 (and I personally add android:textSize="14sp")
from material-about-library.
Yep, currently quite busy - will try and get round to this in the following week. Thanks :)
from material-about-library.
Reopening as I'm not sure why I closed this. Will make these changes or accept a PR for them :)
from material-about-library.
Line 52 in library/src/main/res/layout/mal_material_about_title_item.xml needs fixing
from material-about-library.
Related Issues (20)
- AboutFragment: FATAL EXCEPTION HOT 3
- Migrating from 2.4.2 to 3.x.x HOT 14
- Icons show up as black boxes in 3.1.2 but not 2.4.2 MaterialAboutActionItem Builder HOT 1
- Outlined Card Toggle
- MaterialAboutActionItem receiving null context in some devices
- Does it support badge at item's icon or text?
- Bottom navigation HOT 1
- ScrollView
- Can´t get it to work..please help me HOT 5
- Cards not updating with dynamic content HOT 4
- Override icon tint? HOT 2
- Add AndroidX support HOT 18
- Issue with LTR text on RTL devices
- Making This Library Available to Developers Using Xamarin.Android HOT 3
- Replace String Comparisons with Direct Field Comparisons
- NoClassDefFoundError HOT 13
- Build warnings: 'string too large to encode using UTF-8...' HOT 7
- Remove CardView dependency in favour of MaterialCardView from Material Components HOT 1
- Support for Material Components theming system/DayNight styles HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from material-about-library.