GithubHelp home page GithubHelp logo

Comments (5)

marcardar avatar marcardar commented on June 6, 2024

Thanks Daniel. I've been playing around with:

title: TextAppearance.MaterialComponents.Headline6
subtitle: TextAppearance.MaterialComponents.Subtitle2

but the title looks very big to me, even though Headline6 is supposed to be the smallest. What do you think?

As a workaround I add android:textSize="16sp" (for the title) to make it look nicer, but I'm wary of using non-standard metrics.

Also, should the text in title_item and action_item look the same? If so, should that part be extracted into its own layout xml and then "included" in the two different existing layouts.

from material-about-library.

marcardar avatar marcardar commented on June 6, 2024

I just realised that, anyway, we should be using ?attr/ rather than the style resources directly. And it looks better because we can use the proper text appearance attrs for lists (and no need to tweak the text size):

title: ?android:attr/textAppearanceListItem
subtitle: ?android:attr/textAppearanceListItemSecondary (and personally I prefer to add android:textColor="?android:attr/textColorSecondary")

card title: ?attr/textAppearanceHeadline6 (and I personally add android:textSize="14sp")

from material-about-library.

daniel-stoneuk avatar daniel-stoneuk commented on June 6, 2024

Yep, currently quite busy - will try and get round to this in the following week. Thanks :)

from material-about-library.

daniel-stoneuk avatar daniel-stoneuk commented on June 6, 2024

Reopening as I'm not sure why I closed this. Will make these changes or accept a PR for them :)

from material-about-library.

daniel-stoneuk avatar daniel-stoneuk commented on June 6, 2024

Line 52 in library/src/main/res/layout/mal_material_about_title_item.xml needs fixing

from material-about-library.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.