GithubHelp home page GithubHelp logo

Comments (6)

danielbuechele avatar danielbuechele commented on May 22, 2024

When compiling the Swift project locally, a local JS-file is used. See https://github.com/danielbuechele/goofy/blob/master/Goofy/AppDelegate.swift#L43
But adding a hidden preference or something to change the path of the JS-file would also be nice!

from goofy.

d4rky-pl avatar d4rky-pl commented on May 22, 2024

I'm not sure if it's a good idea to keep .js files on external server, especially unversioned. If you ever switch from AWS to something else, everyone will have a very bad time :)

from goofy.

danielbuechele avatar danielbuechele commented on May 22, 2024

Loading the JS from an external server is super convenient for responding to changes on Facebook's side and quickly adding features. However, linking to a domain that I control and introducing version would make sense.

from goofy.

d4rky-pl avatar d4rky-pl commented on May 22, 2024

Then I guess there're two issues here:

  • moving away from AWS domain and into something like static.goofyapp.com
  • adding either advanced preference or --option to inject custom CSS/JS for debugging and development reasons

from goofy.

danielbuechele avatar danielbuechele commented on May 22, 2024

In the current version you can set a custom URL for the JS in Goofy's Info.plist using GoofyJavaScriptURL

from goofy.

danielbuechele avatar danielbuechele commented on May 22, 2024

The JS-file is now served from another host. There can be specific versions of the JS-file and there is a fallback if there is not JS-file for this specific version.

from goofy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.