Comments (6)
When compiling the Swift project locally, a local JS-file is used. See https://github.com/danielbuechele/goofy/blob/master/Goofy/AppDelegate.swift#L43
But adding a hidden preference or something to change the path of the JS-file would also be nice!
from goofy.
I'm not sure if it's a good idea to keep .js files on external server, especially unversioned. If you ever switch from AWS to something else, everyone will have a very bad time :)
from goofy.
Loading the JS from an external server is super convenient for responding to changes on Facebook's side and quickly adding features. However, linking to a domain that I control and introducing version would make sense.
from goofy.
Then I guess there're two issues here:
- moving away from AWS domain and into something like static.goofyapp.com
- adding either advanced preference or
--option
to inject custom CSS/JS for debugging and development reasons
from goofy.
In the current version you can set a custom URL for the JS in Goofy's Info.plist
using GoofyJavaScriptURL
from goofy.
The JS-file is now served from another host. There can be specific versions of the JS-file and there is a fallback if there is not JS-file for this specific version.
from goofy.
Related Issues (20)
- Phone and video calls have stopped working HOT 1
- 3.5.6
- How to turn off dark mode HOT 1
- JavaScript error in the main process HOT 5
- Always collapse the sidebar? HOT 2
- Goofy doesn't ask for mic and video permissions in Catalina
- Do not disturb HOT 3
- You can't use this feature at the moment...
- Java issue when launching HOT 5
- When using Cmd + number it doesn't jump to the different chat from people
- Blank window.
- Cannot make video and Audio call
- Cannot login
- Dark Mode toggle broken HOT 2
- Goofy marks messages as read with window out-of-focus
- Can't move the window HOT 2
- Main window buttons overflow to graphics HOT 3
- Suggestion: Add the ability to get notifications from specific people only.
- goofyapp.com has expired HOT 2
- Cannot drag window HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from goofy.