Automatically Destroying Bodies, etc in Collision/Dynamics World's Destructors about reactphysics3d

[jagoly]

Actually, I just noticed that RigidBody actually already does this, I misread the documentation. Sorry! However, it certainly does still apply to Collision / Dynamics World, Bodies and Joints, perhaps being more important as it would help with consistency.

[DanielChappuis]

Yes, you are right. A body or a joint cannot outlive the World in which they have been added. However, they life can be shorter. A user should be able to call the destroyBody() or destroyJoint() methods if he wants to remove a body or a joint from the world before the end of the application for instance (for optimization because the object is not visible anymore, etc). Therefore, we need to keep those two methods to manually remove a body or a joint from the world.

I agree with you, the world destructor should be smarter. I propose to change the CollisionWorld and DynamicsWorld destructors so that they call the destroyBody() or destroyJoint() methods on every bodies or joints that have not been removed from the World yet.

It means that the user will still be able to manually remove a body (or joint) but if he doesn't, the World destructor will remove it automatically at the end.

[jagoly]

Yes, that is exactly what I meant. Of course we still need to keep the destroy methods, for that reason. Splendid! :)

[DanielChappuis]

OK perfect. I will take care of this for the next release. Thanks a lot for reporting this.

[DanielChappuis]

I have implemented this in the commit 345afc1 in the develop branch.

This will be available in the next release of the library.