Comments (12)
Hi there - that's very weird. I've not managed to reproduce that - any idea on what causes those to be marked as having changes?
from multi-module-maven-release-plugin.
I got a similar problem, where the plugin asks me to check two files which are symlinks to real files in the same directory.
Removing the symlinks will yield the same error (which is now correct, since they have been deleted but not commited).
Commiting the removed symlinks resolve the error and I can continue with the release.
from multi-module-maven-release-plugin.
I'm not sure what the behaviour with symlinks is supposed to be. For this kind of thing, the plugin just relies on jgit - do you think this is a bug in jgit? In fact, do you consider this to be a bug?
from multi-module-maven-release-plugin.
The symlinks where committed to git, so they where not unstaged changes at least. So yes, I'd consider it a bug. But yeah, probably in jgit; LocalGitRepo just calls isClean it seems? The symlinks are listed from the getUncommitedChanges() list.
from multi-module-maven-release-plugin.
Actually, with jgit 4.0.1.201506240215-r it seems to be fixed! 3.7.1.201504261725-r still has the issue though.
Not sure if there are any incompabilities with 4.0, but it seems to work. All test cases succeeded!
from multi-module-maven-release-plugin.
That's excellent. I won't be able to release it until tomorrow unfortunately.
Thanks a lot for tracking down the problem.
from multi-module-maven-release-plugin.
Note that this may or may not fix the original poster's issues, I only had the symlink related issue.
from multi-module-maven-release-plugin.
Released version 1.2.2 to hopefully fix this. Can you let me know if it works now?
Thanks again.
from multi-module-maven-release-plugin.
Symlinks seems to work fine in 1.2.2, thanks!
from multi-module-maven-release-plugin.
Just realised that this change broke compatibility with Java 6. Unfortunately Java 6 is still important in some places.
I might roll back to the previous version of jgit. So the work around for the issue here is using version 3.2.2
until Java 6 support is dropped.
from multi-module-maven-release-plugin.
FYI: This can be overriden in the project using the plugin:
<plugin>
<groupId>com.github.danielflower.mavenplugins</groupId>
<artifactId>multi-module-maven-release-plugin</artifactId>
..
<dependencies>
<dependency>
<groupId>org.eclipse.jgit</groupId>
<artifactId>org.eclipse.jgit</artifactId>
<version>4.0.1.201506240215-r</version>
</dependency>
</dependencies>
</plugin>
from multi-module-maven-release-plugin.
Maybe I should do it the other way around - just tell Java 6 users to use version 1.2.0 of this plugin and bump the major version and switch to Java 7.
from multi-module-maven-release-plugin.
Related Issues (20)
- Unable to release using github actions. HOT 1
- Test cases have external dependency on M2_HOME environment variable being set
- Use latest version from commit history instead latest greatest for unchanged modules HOT 3
- Use Maven Wrapper HOT 4
- Add option to release with untracked files HOT 3
- HTTPS authentication does not work similar to that of the SCM plugin
- The releaser:release goal does update the version although NoChangesAction is set to ReleaseNone
- Azure DevOps needs separate documentation
- Need documentation or mechanism for re-building a release tag HOT 1
- how to use ${revision} of flatten-maven-plugin together HOT 2
- Howto create javadoc and sources jars wirh the release HOT 1
- Question: Precommit hook for tag creation fails but build continues?
- Aggregator and module POMs at root folder
- Git SSH authentication failing HOT 2
- [deploy] [3.6.1] Cannot release project with submodules with dependency HOT 5
- releases module with fixed dependency version HOT 3
- Version properties and maven-assembly-plugin HOT 6
- Add new versionsReportFormat to generate properties file HOT 1
- Jenkinsfile HOT 2
- Local Plugin dependency not resolved when using -Snapshot HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from multi-module-maven-release-plugin.