GithubHelp home page GithubHelp logo

Comments (5)

danielstjules avatar danielstjules commented on June 10, 2024

You're right - though the current name is a bit verbose, and I'm not sure what I'd name it. Calling it match might not be appropriate, since it returns a boolean rather than the regexp matches (preg_match in PHP, String.prototype.match in JS, re.match in python)

from stringy.

brad-jones avatar brad-jones commented on June 10, 2024

preg_match doesn't return the matches, it fills them via the third parameter.
You could have matchesPattern or whatever you want to call it do likewise.

So for example:

if (s("string")->matchesPattern("pattern", $matches))
{
    echo 'We found at least 1 match.';
    print_r($matches);
}

from stringy.

danielstjules avatar danielstjules commented on June 10, 2024

Oops, you're right. That's not exactly an API I'd like to be consistent with though.

from stringy.

danielstjules avatar danielstjules commented on June 10, 2024

Note that the behavior would need to be changed from using mb_ereg_match to mb_ereg, since mb_ereg_match imposes ^ (matching from start of str)

from stringy.

danielstjules avatar danielstjules commented on June 10, 2024

Closing for now. Would like to explore an alternative API.

from stringy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.