Library improvements about stringy

[danielstjules]

Alright! My 3rd point was about the fact that "substringing" is very common when manipulating strings, that's why I expected these methods to be merged in the main library, allowing the use an out-of-the-box swiss knife, requiring no config and no overriding.

I definitely think the package is useful, I just think it's hard to come up with terse method names that describe their behaviour. For example:

s('What are your plans today?')->substringAfterFirst('plans ');
// => "today"

// An equivalent using only core methods
s('What are your plans today?')->split('plans ')[1] ?: false

substringCount
// same as countSubstr in Stringy core

// Some of the other methods require a bit more aerobatics with just core,
// so I can see their benefit :)

The core library def has quite a few "substring" methods already :) But I think traits are the right way to go, letting people easily customize at will!

[danielstjules]

@TCB13 Agreed! Building off the core methods can get verbose too for some of those operations as the array primitives in PHP aren't great. Definitely appreciate the library :)

[danielstjules]

• Package renaming sounds fine, probably easier to remember as you said
• Join sounds good 👍
• I don't think SubStringy belongs in the core, and could probably be implemented as a Trait if you wanted a bit more flexibility :) TCB13/SubStringy#1 #87 (comment)

[TCB13]

@bpolaszek I had this SubStringy discussion previously with @danielstjules - the first versions were actually a PR to this repo. There are also other "extensions" that follow this principle.

We're currently in the process of making SubStringy into a trait.

[TCB13]

@bpolaszek @danielstjules TCB13/SubStringy is now a trait.

[bpolaszek]

Hello @danielstjules @TCB13,

Alright! My 3rd point was about the fact that "substringing" is very common when manipulating strings, that's why I expected these methods to be merged in the main library, allowing the use an out-of-the-box swiss knife, requiring no config and no overriding.

But I understand your point, and the use of a trait is indeed a better approach that a vertical inheritance.

Do you want me to do a PR for points 1 & 2?

Thank you,
Ben

[danielstjules]

@TCB13 Awesome! :)

[TCB13]

@danielstjules An equivalent using only core methods those methods are hard on the eyes. This is one of the reasons why I added the substring methods. Easier to use specially when you use an IDE / sublime.