Comments (4)
I think it has to do with caching. Since the "civet coffeeInterpolation" prologue directive changes the behavior of strings if it is followed by a string it may be parsed and cached. I'd prefer to not add strings to the non-cached list since that could affect parsing performance throughout the whole file.
Fine tuning the directive prologue parsing to only check for simple strings may fix this.
from civet.
It may be an open question whether we should mangle top level directive prologues. In this case "Hello #{name}!" is parsed as a JS prologue in the spec and probably shouldn't be interpolated no matter what civet config options are specified.
from civet.
Oh, I forgot about JS prologues. This behavior makes sense then, I think.
It might make sense to just clear the cache after parsing the Civet directive, though I'm not sure whether this is ever an issue.
from civet.
I probably need to add a comment in the parser since I forgot about it until reading the code :)
from civet.
Related Issues (20)
- Cannot use `@#` for `this.length` in `while` condition HOT 1
- Unbounded for loop
- Arrow functions after binary operators don't parse right HOT 1
- Ref hoisting in `async do` HOT 1
- `if const` allows `?` in identifier
- Empty spread invents identifier
- try...else HOT 11
- ts-expect-error before assignment from for expression HOT 4
- `[a, ..., b] = c` doesn't declare `ref`
- Pattern matching in condition with literals generates incorrect code
- Optional-chained operators HOT 2
- "try coalescing" / catch operator
- Type specification in `for`
- Negative index access fails on its own line
- Deep `....`rest operator HOT 2
- `::#` doesn't work in type position HOT 3
- Eliminating `return` after `loop` in some cases HOT 3
- `yield x; loop` has strange behavior
- Trailing pipe or property access should expressionize statement HOT 1
- ASI fails before symbol-typed property
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from civet.