GithubHelp home page GithubHelp logo

explorer-gate's People

Contributors

daniildulin avatar

Watchers

 avatar  avatar

explorer-gate's Issues

Code review

1. Use a better name for this function. Maybe handleTxs?

https://github.com/daniildulin/minter-explorer-gate/blob/a0b881a93f20a26893cd852e19ea6d18ef21cde6/api/main.go#L54

2. Refactor this lines:

https://github.com/daniildulin/minter-explorer-gate/blob/a0b881a93f20a26893cd852e19ea6d18ef21cde6/core/main.go#L27-L32

	proto := `http`
	if config.GetBool(`minterApi.isSecure`) {
		proto = `https`
	}
	apiLink := proto + `://` + config.GetString(`minterApi.link`) + `:` + config.GetString(`minterApi.port`)

3. Add getNonce method

4. Add comments to all methods

5. This lines should be used select {} block to support timeouts

https://github.com/daniildulin/minter-explorer-gate/blob/a0b881a93f20a26893cd852e19ea6d18ef21cde6/handlers/transactions.go#L43-L50

Example:

select {
  case <-ee.On(strings.ToUpper(tx.Transaction), emitter.Once):
    // return OK
  case <-time.After(15 * time.Second):
   // return FAIL
}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.