Comments (5)
would this be an option that can be set globally for stylix?
The options.stylix.targets.<TARGET>.wallpaper
options would be <TARGET>
specific, similar to options.stylix.targets.<TARGET>.enable
.
Based on the following use cases, it makes sense to add a stylix.enableWallpaper
option complementary to stylix.autoEnable
:
-
Get color scheme from
stylix.image
without settingstylix.image
as wallpaper:stylix = { enableWallpaper = false; image = image; }
. -
Get color scheme from
stylix.image
and setstylix.image
as wallpaper:stylix = { enableWallpaper = true; image = image; }
. -
Manually declare color scheme (
stylix.base16Scheme
) and entirely ignorestylix.image
:stylix = { base16Scheme = base16Scheme; enableWallpaper = false; image = null; }
.
For reference, it has been considered to better rename the stylix.autoEnable
option. Additionally, these use cases somewhat correspond to the slideshow feature suggestion.
I actually want to disable stylix's wallpaper functionality in favor of plasma-manager's wallpaper module as that module lets me set multiple wallpapers for KDE Plasma.
My previously mentioned use cases and an additional options.stylix.targets.kde.wallpaper
would resolve this scenario. For reference, I added the kde
module to the Steps required to resolve this tracking issue.
This is my current thinking which depends on #200
- If
sylix.image
is set (currently mandatory) then we configure allenabled
wallpaper services.
- It shouldn't be the responsibility of sylix to decide (and maintain code for) which wallpaper service should be used.
- If
sylix.image
is not set then we do not configure any wallpaper services.
- If the user doesn't want wallpaper then this is the way.
- If the user wants to do something custom (e.g. a folder with rotating images) they now have unobstructed control to configure their chosen service.
This corresponds to my previously mentioned use cases, except that stylix.enableWallpaper
provides a default implementation for setting wallpapers:
- It shouldn't be the responsibility of sylix to decide (and maintain code for) which wallpaper service should be used.
Regarding the implementation of stylix.enableWallpaper
, we could add additional guards, similar to lib.stylix.mkEnableTarget
:
Line 42 in 97dcf3c
Considering that the scope of wallpaper optionality is larger than initially anticipated, it might be better to extend the scope of this tracking issue. Consequently, #200 is included and the following statement is removed from this issue's top-level description:
Unlike #200, this does not optionalize the
stylix.image
declaration. Instead, it should be possible to disable wallpapers being set, when supported.
from stylix.
Hey @trueNAHO would this be an option that can be set globally for stylix? I actually want to disable stylix's wallpaper functionality in favor of plasma-manager's wallpaper module as that module lets me set multiple wallpapers for KDE Plasma.
from stylix.
So, an option like enableWallpaper
under each target?
from stylix.
So, an option like
enableWallpaper
under each target?
Yes, I had the same idea. However, I would simplify the option name to wallpaper
.
For consistency, we could implement and use a helper function, like mkEnableWallpaper
, with an appropriate description
, similar to mkEnableTarget
:
options.stylix.targets.hyprland = let
target = "Hyprland";
in {
enable = lib.stylix.mkEnableTarget target true;
wallpaper = lib.stylix.mkEnableWallpaper target false;
}
from stylix.
This is my current thinking which depends on #200
- If
sylix.image
is set (currently mandatory) then we configure allenabled
wallpaper services.- It shouldn't be the responsibility of sylix to decide (and maintain code for) which wallpaper service should be used.
- If
sylix.image
is not set then we do not configure any wallpaper services.- If the user doesn't want wallpaper then this is the way.
- If the user wants to do something custom (e.g. a folder with rotating images) they now have unobstructed control to configure their chosen service.
from stylix.
Related Issues (20)
- gtk: support theming at the system level HOT 3
- Compatibility issue with Plasma-manager HOT 8
- Zellij module has bad contrast HOT 2
- [BUG] Some or every QT apps will not open HOT 10
- foot + tmux + fish = frozen shell HOT 4
- kde: add Qt6 and non-KDE Qt theme support
- GDM Login photo support HOT 3
- idea: support a cross browser dark mode extension like dark-reader HOT 6
- Ability to stop Stylix from starting Hyprpaper service automatically HOT 5
- chromium: `programs.chromium.enable` now installs chromium HOT 2
- base16Scheme expected a set but found a string error HOT 10
- specialisations inherit the parents lib attrset HOT 2
- neovim: theming is incompatible with lazy.nvim HOT 2
- chromium: `stylix.targets.chromium` does not exist HOT 3
- VSCODE: add font size settings HOT 1
- Stylix theme won't apply to vscode after update HOT 4
- Suggest: Add support for changing icon theme from stylix HOT 2
- stylix: re-add `flake-utils` dependency HOT 2
- fish: `base16-fish` causes linux console (tty) to output `linux`
- fish: `base16-fish` script runs twice
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stylix.