GithubHelp home page GithubHelp logo

Comments (6)

lovesegfault avatar lovesegfault commented on August 26, 2024

cc. @SomeGuyNamedMy

from stylix.

danth avatar danth commented on August 26, 2024

I think the issue is that the accent colours (base09 to base0F) are not guaranteed to contrast with the foreground colour (base05).

A few options we could choose from:

  • Change the text to base00 when an accent is used as the background
  • Remove accent colours used as backgrounds and colour the text instead
  • Remove accent colours entirely

from stylix.

SomeGuyNamedMy avatar SomeGuyNamedMy commented on August 26, 2024

@danth, might be a good idea to revert back to before the pull request, looking back on the module, it isnt anyware near good enough.

from stylix.

SomeGuyNamedMy avatar SomeGuyNamedMy commented on August 26, 2024

whats everyone's opinion on adding an option to disable background colors by side in the module?

from stylix.

danth avatar danth commented on August 26, 2024

I would have an option, as some people will prefer a simpler look.

from stylix.

SomeGuyNamedMy avatar SomeGuyNamedMy commented on August 26, 2024

what do we want the options to default to?

from stylix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.