GithubHelp home page GithubHelp logo

Comments (21)

steffenhaak avatar steffenhaak commented on May 23, 2024 5

The fix released in v1.9.4 unfortunately breaks flutter web usage. Using v.1.9.4 in web, one can no longer put in more than one character (tested on Chrome/MacOS).

from flutter_chips_input.

bartekpacia avatar bartekpacia commented on May 23, 2024 4

Hi, I was able to reproduce this bug. (on Android, iOS works fine)

Android Emulator + input from PC keyboard

demo pc kb

Android Emulator + input from on-screen keyboard
demo

iOS Simulator + input from PC keyboard
demo1

Flutter version output:

Flutter 1.17.0 • channel beta • https://github.com/flutter/flutter.git
Framework • revision d3ed9ec945 (2 weeks ago) • 2020-04-06 14:07:34 -0700
Engine • revision c9506cb8e9
Tools • Dart 2.8.0 (build 2.8.0-dev.18.0 eea9717938)

Flutter Doctor output:

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v1.17.0, on Mac OS X 10.15.4 19E287, locale en-PL)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 11.3)
[✓] Chrome - develop for the web
[!] Android Studio (version 3.6)
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
[✓] IntelliJ IDEA Ultimate Edition (version 2020.1)
[✓] VS Code (version 1.44.2)
[✓] Connected device (3 available)

! Doctor found issues in 1 category.

from flutter_chips_input.

MobiliteDev avatar MobiliteDev commented on May 23, 2024 2

I have the same problem on my android emulator.
The problem is the first character is saved on the first time.

I you type 'a' and select 'Alpha', next if you directly type 'b', the first chips disappears and there is 'ab' written on the inputchips.

Seems the text is not cleared after the first chip selection.

from flutter_chips_input.

Mosc avatar Mosc commented on May 23, 2024 2

So I've been looking into this as well after experiencing this issue myself. As far as I can tell, selecting a suggestion after typing one character causes the _updateTextInputState method to update the _textInputConnection as expected, except on the next trigger of updateEditingValue, the value appears to not have taken into account the aforementioned update.

One workaround that has worked for me is to simply recreate the text input connection on every text input state change. This can be found at https://github.com/Mosc/flutter_chips_input/commit/321544efea98a056ab94e066453ad4d2b841b1b6. I'm hesitant to create a pull request because this doesn't feel like a proper fix, yet it might help out others who experience the same issue. Please don't count on my fork being available forever, but try it out by updating your pubspec.yaml as follows:

flutter_chips_input:
  git:
    url: https://github.com/Mosc/flutter_chips_input
    ref: 321544efea98a056ab94e066453ad4d2b841b1b6

from flutter_chips_input.

danvick avatar danvick commented on May 23, 2024 1

Thanks for shedding more light on this @bartekpacia.

I've finally been able to reproduce. So just to be clear this issue occurs only:

  1. When using the Android Emulator - not on Android device
  2. When using the on-screen emulator keyboard

Right?

I'll try to investigate the cause of the bug and see. I suspect it may be a Flutter issue related to #1

from flutter_chips_input.

Albert221 avatar Albert221 commented on May 23, 2024 1

It happens on physical devices too and using both physical and onscreen keyboard

from flutter_chips_input.

FtADev avatar FtADev commented on May 23, 2024 1

The fix released in v1.9.4 unfortunately breaks flutter web usage. Using v.1.9.4 in web, one can no longer put in more than one character (tested on Chrome/MacOS).

That happened to me too! You can type only one character in web in all versions: 1.9.4, 1.9.0, 1.7.0

from flutter_chips_input.

danvick avatar danvick commented on May 23, 2024

Hi @Albert221,
Kindly note that the reason why the option is not suggested the second time you're trying to type is that you have already picked the option.

Unless I'm misunderstanding the issue.

from flutter_chips_input.

Albert221 avatar Albert221 commented on May 23, 2024

Let me explain the issue in more detail.

When I type a in the input I have the Alpha suggestion, which is fine. I then select this suggestion so it appears in the input as this Alpha chip. Here's the problem: after that when I type another character, the chip disappears and is replaced with the a character from the very beginning. I reckon that's unwanted behavior. When I selected the chip it should stay there unless I delete it with keyboard or state.deleteChip(), not when I type more stuff into the input.

I hope you understand my issue now.

from flutter_chips_input.

danvick avatar danvick commented on May 23, 2024

I now get the point. That would be highly undesirable behavior.

I've however tried to reproduce this issue to no avail.

Could you kindly share versions of the package or Flutter channel you're on?

from flutter_chips_input.

Albert221 avatar Albert221 commented on May 23, 2024

I created a simple repository with some code to reproduce the issue: https://github.com/Albert221/flutter_chips_input_issue_34

Just clone the repo, run flutter pub get and then flutter run and do the following to replicate the issue:

  1. Tap on the input
  2. Type a
  3. Tap the Alpha suggestion
  4. Type a

You should see aa in the input field instead of <Alpha> a.


I've also created a Flutter Driver test, but it's not working as expected, but you can run it with

flutter drive --target=test_driver/app.dart

Here's my flutter --version:

Flutter 1.16.4-pre.50 • channel dev • https://github.com/flutter/flutter.git    
Framework • revision d14a301e41 (2 weeks ago) • 2020-03-31 19:14:22 -0400       
Engine • revision fc5b44c901
Tools • Dart 2.8.0 (build 2.8.0-dev.18.0 e8c4aed700)

from flutter_chips_input.

Albert221 avatar Albert221 commented on May 23, 2024

@danvick were you able to correctly reproduce the issue?

from flutter_chips_input.

danvick avatar danvick commented on May 23, 2024

Not even with your dev channel.

from flutter_chips_input.

KarnerTh avatar KarnerTh commented on May 23, 2024

@danvick Thanks for investigating, but happens to me also on a physical device

from flutter_chips_input.

danvick avatar danvick commented on May 23, 2024

Noted @Albert221 @KarnerTh.

I think I've found the culprit. Let me now work on a fix.

from flutter_chips_input.

danvick avatar danvick commented on May 23, 2024

Not quite yet. I'll reopen this.

from flutter_chips_input.

fildabert avatar fildabert commented on May 23, 2024

I have the same problem too on an Android device, but not on an Android emulator

from flutter_chips_input.

tbillson avatar tbillson commented on May 23, 2024

Having the very same issue, both on Android Emulator and devices.

from flutter_chips_input.

tbillson avatar tbillson commented on May 23, 2024

This issues only happens on the very first chip. I hope it throws some light on the subject

from flutter_chips_input.

tbillson avatar tbillson commented on May 23, 2024

from flutter_chips_input.

nlfiedler avatar nlfiedler commented on May 23, 2024

For those still using this library, I have given up on waiting for danvick and created a new fork. I've integrated all of the open PRs and fixed a bug or two. Still working on another bug related to backspace on macOS.

https://github.com/nlfiedler/choose_input_chips

from flutter_chips_input.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.