GithubHelp home page GithubHelp logo

Comments (4)

DanWahlin avatar DanWahlin commented on July 21, 2024

I'm not planning that for this jump start app - it's intended to be focused 100% on Angular to help people get started with core concepts. I made add that type of functionality so another app I'm working on though potentially.

from angular-jumpstart.

ammar91 avatar ammar91 commented on July 21, 2024

I understand the intention of this getting started project. Actually, I am having a hard time making my routes secure. There is another repo that demonstrate how that could be done but I noticed the controller still initiate by having that way and probably that will not best approach according to me..

https://github.com/auth0-blog/angular2-authentication-sample

Then I look at the Angular CanActivate decorator that can be applied to a Component to activate it only if certain condition matches. But there are two issues

  1. We can not inject dependency in CanActivate decorator (at least with the current beta version). There is a long debate and several solutions have been suggested to resolve this but I think it will be possible when RC come out. But there is a workaround that can make it possible with current beta version

angular/angular#4112

  1. Having CanActivate decorator on every Component would probably not a best approach. There should be one single place where we can control the activation of each component. Like secure routes component could only be accessible if user logged in.

That's why I was wondering if you could cover the above in this project. If you just simulate the authentication and activate secure route component based on user logged in or not, that would be really helpful. But if you think that will be the out of the scope of this project, any suggestion on this concern would be helpful as well.

from angular-jumpstart.

DanWahlin avatar DanWahlin commented on July 21, 2024

Yeah - definitely a lot to consider there. I've used or seen the options you mention above but haven't looked into a more global approach yet. Haven't tried putting @CanActivate at the root component level to see if it could filter every route request and then accept/reject....may not support that (just need time to try it). :-)

from angular-jumpstart.

ammar91 avatar ammar91 commented on July 21, 2024

Agree, it would be interesting to see if this can be done globally. Please update if you get a chance to try this out.

Thanks:)

from angular-jumpstart.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.