GithubHelp home page GithubHelp logo

Comments (3)

poorcoder avatar poorcoder commented on June 22, 2024

Hi @dapriett ,
I made some changes on files and I made it but is it right way to do it or not... I am not sure...

""My changes""
map-view-common.js
after notifyMarkerTapped function added notifyMarkerInfowindowTapped function...

    // infowindow
    MapView.prototype.notifyMarkerInfowindowTapped = function (marker) {
        var args = { 
            eventName: MapView.markerInfowindowTapEvent,
            object: marker 
        };
        console.log('notifyMarkerInfowindowTapped...')
        this.notify(args);
    };

and after
MapView.markerSelectEvent = "markerSelect";
I added
MapView.markerInfowindowTapEvent = "infowindowTap";

and after added to map-view.ios.js

// after mapViewDidTapMarker function
    // infowindow
    MapViewDelegateImpl.prototype.mapViewDidTapInfoWindowOfMarker = function (mapView, gmsMarker) {
        var owner = this._owner.get();
        if (owner) {
            var marker = owner.findMarker(function (marker) { return marker.ios == gmsMarker; });
            owner.notifyMarkerInfowindowTapped(marker);
        }
    };

from nativescript-google-maps-sdk.

dapriett avatar dapriett commented on June 22, 2024

Looks good to me - then in android you can setOnInfoWindowClickListener with a OnInfoWindowClickListener - similar to how we do it for gMap.setOnMarkerClickListener

You can do a pull request and make the changes, I can merge them in.

from nativescript-google-maps-sdk.

poorcoder avatar poorcoder commented on June 22, 2024

Ok I will try to solve android version too and then will make a pull request...
Thank you...

from nativescript-google-maps-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.