darcyclarke / detect.js

:mag: Library to detect browser, os and device based on the UserAgent String

👋 Hi, I'm Darcy!

I'm building something new... was previously the manager for the npm & gh CLI/OSS Teams at GitHub

tl;dr introduction...

Experience includes (but is not limited to):

• 👔 Directing managers, teams, leads & ICs (engineering, devops, security, product & design)
• ❤️ Leading with empathy & a holistic approach to problem solving
• 🌱 Leveraging a growth mindset & culture to build & scale teams
• ⭐️ Fostering a safe environment to unlock individuals potential to be their best selves
• ☁️ Tackling complex problem areas with world-wide impact & scale
• 🛠 Developing world-class products & experiences for B2C, B2B & B2E customers/users
• 📊 Defining, implementing & monitoring processes & tools to meet industry standards & best practices
• 🔎 Navigating uncertainty, leveraging two decades of experience, strong network & organizational counterparts
• 🎤 Speaking at events on technology, product development, building communities & culture
• 🎉 Organizing & running community office hours, meetups & conferences
• ✍️ Writing for & featuring in mass media publications
• 🌎 Contributing to numerous open source projects, foundations & initiatives
• 🎓 Teaching classes & workshops for post-secondary & professional development audiences

Professional interests include (but are not limited to):

• ✨ Leadership
• 🤖 Tooling & Automation
• ⛓ Software Supply Chain
• 🛡 Security
• 💬 Developer Relations
• 🧪 Product Strategy & Development
• 🎨 User Experience & Interface Design
• 💼 Startups & Entrepreneurship

detect.js's Issues

Add Manufacturer Support

Display manufacturer of a device (ie. "ipad" is "apple").

Yandex Browser

Please add Yandex Browser detection. It always says that Yandex Browser is Google Chrome. Example of Yandex Browser user agent string:

Mozilla/5.0 (Windows NT 6.2; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/37.0.2062.120 YaBrowser/14.10.2062.12544 Safari/537.36

Would you please consider adding git tag for each version?

Hi there,

I'm Peter from CDNJS, the free and open source and community-driven public front-end web library CDN service, there is a request to add Detect.js on CDNJS, however, we can not easily decide the versions on the repo, it'll be good to add tag for the versions, and also our auto-updater can automatically add the new versions of Detect.js in the future, so hope you can consider that, thank you!

cc cdnjs/cdnjs#7157

JavaScript error on IE11

See attached screenshot. Works correctly in Chrome and Firefox but generates a JavaScript error on Windows 7 Enterprise SP1 running IE11 update 11.0.28.

iOS firefox userAgent include"FxiOS"

Detect.js : ua.browser.family = Mobile Safari

It's not expect

Add Device Class Support

ie. "ipad" is "tablet" etc.

Windows 10 Detection

Pull Request #29
Although windows 10 is still in development I feel that it would be a good idea to detect it.

IE 11 doesn't detected

User agent Mozilla/5.0 (Windows NT 6.1; Trident/7.0; .NET4.0C; .NET4.0E; rv:11.0) like Gecko detected how Other

Pls fix this.

Add Edge Detection

As Windows 10 is being launched today, it's time to update with Edge and Win10 detections. Win10 already made in #30 (not tested), we just need a Edge detection.

MSDN Windows10 UserAgents

Add semver tags

This is necessary for e.g. Bower in order to work correctly.

do you have npm library?I want to install it in my node project, but i can not find it by the name of detect

do you have npm library?I want to install it in my node project, but i can not find it by the name of detect

Undefined variable "breaker"

In the non-native forEach fallback code, a breaker variable is used, but it is never defined, causing errors in IE7-8. Am I missing a dependency, or does the variable need to be set somewhere?

BusinessRules.RulesEngine

I am not able to instantiate BusinessRules object. Does this exist, or was this removed?

MS Edge is detected as Chrome

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.135 Safari/537.36 Edge/12.10240

Create a demo page

We need to create a demo page to show and use as real test.

Pushing directly to github pages is good.

Can provide a list for supported Operation System and Browser in README?

There are many library to detect operation system and browser from user agent.

If provide a list for supported operation system and browser list like device-detector, others may easy to find the suitable library

Thank you if consider the advice!

Add type definitions to support import in TypeScript

Mobile Edge on IOS says it is Safari

Thanks! It is there in the user agent.

Opera 19, invalid detected

source: "Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.107 Safari/537.36 OPR/19.0.1326.63"

Result:
browser: Object
family: "Chrome"
major: 32
minor: 0
name: "Chrome 32"
patch: 1700
version: "32"

Microsoft Egde detected as Chrome

I tested the lib on browserstack.com using the IE13 setting (wich apparently is the EDGE browser).
The test result shows Chrome as the Browser wich is not correct in this case:

IE8 - SCRIPT5022: Exception thrown and not caught

Getting error in IE 8
"SCRIPT5022: Exception thrown and not caught"

I'm using the newest version -> @Version 2.2.1
35 if (typeof callback !== "function") {
36 throw new TypeError(callback + " is not a function");
37 }

do not detect Android 9?

Cannot show the version of android 9, could you support?

Wrong Firefox detection on Android

It detects the browser name "Android" and the version "4" when using a Firefox v41 on a Android 4 Tablet.

Meet Windows Phone 8.1 - crazy user agent

new windows phone 8.1 - mobile IE have user agent:

Mozilla/5.0 (Mobile; Windows Phone 8.1; Android 4.0; ARM; Trident/7.0; Touch; rv:11.0; IEMobile/11.0; NOKIA; Lumia 620) like iPhone OS 7_0_3 Mac OS X AppleWebKit/537 (KHTML, like Gecko) Mobile Safari/537

It detected as Android.

can support detect iphone x ?

do not detect Opera!!!

maybe its a new user agent string??

example of opera 24

"Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/37.0.2062.94 Safari/537.36 OPR/24.0.1558.53"

BB10 detected as "Desktop" device

I'm using Chrome -> Emulation -> User Agent -> Spoof user agent -> BlackBerry -- BB10

source: "Mozilla/5.0 (BB10; Touch) AppleWebKit/537.1+ (KHTML, like Gecko) Version/10.0.0.1337 Mobile Safari/537.1+"

Object {family: "Other", type: "Desktop", manufacturer: null}

Fix security issues to address github dependabot security concerns.

They seem like easy suggestions to implement, something a newbie like me could maybe pull off.

Does this library is on bower.io?

Identify Windows 8.1

Windows 8.1 is identified as only "Windows" for the OS family and name. Windows 8.1, which has Windows NT 6.3 in the user agent (I've seen others looking for Windows 8.1 too) is missing from the regexes.

List of all families

Is there a list of all possible values for:
ua.browser.family ?

Add externs file for Google Closure Compiler

Pleas add a externs file for use with the Google Closure Compiler:
https://github.com/google/closure-compiler/tree/master/contrib/externs

JSHint issues

I accidentally ran JSHint over detect.js when I brought it into our codebase, and it found a few issues. You can see them by just using http://www.jshint.com/

A few of them are more worrying to me than others, like parseInt not using a radix.
But I haven't actually seen the code before so I don't feel equipped to make a judgement call on the warnings.

So.. its an FYI, feel free to close.

Adding Detect.js to Bower

@darcyclarke Would you be willing to add this to the Bower registry? If so, I can submit a pull request.

Chrome on tablets is incorrectly identified as a Desktop device

e.g.
Mozilla/5.0 (Linux; Android 4.2.2; GT-P5210 Build/JDQ39) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.99 Safari/537.36

console.log(ua.device.type);
Desktop