GithubHelp home page GithubHelp logo

Comments (2)

dariogriffo avatar dariogriffo commented on July 24, 2024

Hi @BorisGerretzen, thanks for this, I would decline this, and the reasons are

  • you should not be able to change the response, this allows to unexpected behaviour down the road and bugs. Immutability is a great friend in a developers life!
  • you would like to have separated layers in the app, and don't tie your database models to your Open Banking model, you may want to change the provider to let's say TrueLayer, and their model might be slightly different.
    Each layer should have their own models and you can use something like Automapper to make the mapping seamlessly between your layers.
    Hope this makes sense

from nordigen.net.

BorisGerretzen avatar BorisGerretzen commented on July 24, 2024

Hi, I understand that immutability is nice to have but by using private set it is only mutable from the class itself, from outside it is still mutable.

I get your point about the layers though, I will try Automapper. Thanks for your time!

from nordigen.net.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.