GithubHelp home page GithubHelp logo

Comments (5)

nex3 avatar nex3 commented on August 25, 2024

As long as we're only supporting Dart 2 (which appears to be the case based on the current pubspec), we can do this much more simply by just using cast() everywhere and deleting the TypeSafe wrappers.

from collection.

matanlurey avatar matanlurey commented on August 25, 2024

Definitely, I just am trying to be nice to users - in my own tests it looks like the type of errors thrown by Dart2 versus thrown currently by the wrappers are not exactly the same.

from collection.

nex3 avatar nex3 commented on August 25, 2024

How much does that buy us in practice? I don't see how code could ever actually construct a TypeSafeList with your proposed intermediate implementation.

from collection.

matanlurey avatar matanlurey commented on August 25, 2024

Until the VM and Dart2JS enforce strong mode, strong-mode typed lists will not throw. So you could potentially be using .typed for safety, and it throws in DDC but not Dart2JS.

from collection.

nex3 avatar nex3 commented on August 25, 2024

But if dart2js isn't using strong mode semantics, then base is List<E> will always be true (because <E> is erased) and nothing will throw anyway.

from collection.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.