Add support for `preview-dart-2` about webdev

[dgrove]

Removing block label, as dart-lang/sdk#32188 has been closed.

[alorenzen]

Note, this is blocked by dart-lang/sdk#32188

[kevmoo]

We have a matrix here.

We could have webdev --preview-dart-2 run dart2js in the right mode.

But invoking webdev on the VM w/ --preview-dart-2 would be some other magic (likely pub global run --preview-dart-2 webdev or some such.

Then for the full effect: pub global run --preview-dart-2 webdev serve --preview-dart-2

[handicraftsman]

dart-lang/sdk#32188 (comment)

[kevmoo]

This would ONLY work for dart2js. Users would have to use `DART_VM_OPTIONS=--preview-dart-2" for the VM.

Still interesting?

[alorenzen]

@kevmoo let's at least enable dart2js/ddc with passing --preview-dart-2 to build_runner. We should probably go ahead and turn this on by default.

It's a shame that there's no other way to enable for the VM, but hopefully we're close enough to flipping the default there that angulardart/angular#1353 is enough for now.

[natebosch]

let's at least enable dart2js/ddc with passing --preview-dart-2 to build_runner.

There is no reasonable way to support this other that also plumbing special support for this flag through build_runner as well which would violate our goal of not having special understanding of the compilers.

We don't have any syntax to allow merging arguments in to some list of Strings option on a builder which is what would need to happen here.

[dgrove]

We are going to flip the flag very soon on the SDK, so if you're willing to clean up afterwards, that's another possibility.

[alorenzen]

dart-lang/sdk#32188 didn't completely fix the issue, see dart-lang/sdk#33460. So we're still blocked here.

The work-around is to use DART_VM_OPTIONS=--preview-dart-2 pub global run webdev build

[matanlurey]

Is this done "enough" now that the default is Dart2?

[kevmoo]

Yeah. Need to roll to support latest build_runner, but that's orthogonal

…

On Sat, Jun 23, 2018 at 12:02 PM Matan Lurey ***@***.***> wrote: Is this done "enough" now that the default is Dart2? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#54 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABCihg63O_HbqMIEVj8g64Dhj5oR9v1ks5t_pDGgaJpZM4T-n0A> .