Comments (5)
I think we can raise another KeyError for incorrect dimensions
Ya, probably can raise a better error stating the patch doesn't have this coord/dimension.
also simply make dimensions not case-sensitive
Not so sure on this one. Ignoring case sensitivity smells too much like fortran ;)
from dascore.
spool.chunk(Time=None)
raises a KeyError as below.
Unless you have renamed the dimension, it should be "time" not "Time", try again with
spool.chunk(time=None)
from dascore.
Ah, I see. I was in a rush and did not notice that typo. I think we can raise another KeyError for incorrect dimensions and also simply make dimensions not case-sensitive. What do you think?
from dascore.
Also, is spool.chunk(time=None)
expected to chunk the spool while there are gaps between patches? It seems it doesn't and just keep the spool size as is.
from dascore.
Need to set "tolerance" to a higher value to allow chunking when there are small gaps between patches. For example:
spool.chunk(time=None, tolerance=10)
Future work: To merge patches with big gaps, we need to lose the evenly sampled requirement and merge coords as are. We then need to make the spool evenly sampled by filling the gaps with NaNs or zeros.
from dascore.
Related Issues (20)
- Cross references in note section broken
- timedelta's should work with units HOT 3
- Enforce int dtypes in select when samples is True HOT 1
- spool with zero patches for binary data HOT 3
- patch.dft() does not change data_type HOT 2
- dft should be idempotent
- velocity_to_strain_rate function issues HOT 1
- spool.concatenate with new dimension has incorrect shape HOT 7
- DASCore fails to read training data for phasenet DAS HOT 3
- patch.attrs.history should be a tuple not a list
- Spool.concatenate does not support directory spool
- Read support for TDMS HOT 13
- OptoDAS channel numbering ignores spatial decimation of original file HOT 9
- numpy problem HOT 1
- can't load saved correlation data in DASDAE format HOT 2
- Spool.select does not raise when a bad kwarg is entered as a coordinate HOT 1
- Spool.select raises TypeError when an integer is entered
- Spool.chunk raises NotImplementedError when units are applied HOT 1
- Patch.whiten on a dft patch expects kwargs range in time instead of freq
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dascore.