GithubHelp home page GithubHelp logo

Comments (5)

d-chambers avatar d-chambers commented on September 27, 2024 1

I think we can raise another KeyError for incorrect dimensions

Ya, probably can raise a better error stating the patch doesn't have this coord/dimension.

also simply make dimensions not case-sensitive

Not so sure on this one. Ignoring case sensitivity smells too much like fortran ;)

from dascore.

d-chambers avatar d-chambers commented on September 27, 2024

spool.chunk(Time=None) raises a KeyError as below.

Unless you have renamed the dimension, it should be "time" not "Time", try again with

 spool.chunk(time=None)

from dascore.

ahmadtourei avatar ahmadtourei commented on September 27, 2024

Ah, I see. I was in a rush and did not notice that typo. I think we can raise another KeyError for incorrect dimensions and also simply make dimensions not case-sensitive. What do you think?

from dascore.

ahmadtourei avatar ahmadtourei commented on September 27, 2024

Also, is spool.chunk(time=None) expected to chunk the spool while there are gaps between patches? It seems it doesn't and just keep the spool size as is.

from dascore.

ahmadtourei avatar ahmadtourei commented on September 27, 2024

Need to set "tolerance" to a higher value to allow chunking when there are small gaps between patches. For example:
spool.chunk(time=None, tolerance=10)

Future work: To merge patches with big gaps, we need to lose the evenly sampled requirement and merge coords as are. We then need to make the spool evenly sampled by filling the gaps with NaNs or zeros.

from dascore.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.