GithubHelp home page GithubHelp logo

Comments (10)

samueljrz avatar samueljrz commented on May 30, 2024 2

By the way, great project, I saw it as a great tool for the Open Telemetry community. It's already helping me a lot and I think I have a lot of resources to have hahaha.

from otelbin.

samueljrz avatar samueljrz commented on May 30, 2024 1

I would like to develop and contribute to this feature if possible. Can I assign it to me?

from otelbin.

samueljrz avatar samueljrz commented on May 30, 2024 1

I thought to put it on the share section also would be a nice fit. So I did it both ways, so I could show it and get a second opinion. Just design part, tomorrow I'll write the logic part.

Screenshot 2023-11-14 at 00 03 15 Screenshot 2023-11-14 at 00 04 14

from otelbin.

samueljrz avatar samueljrz commented on May 30, 2024 1

I managed to raise the PR, but I saw that there were some nuances to resolve. Tomorrow I will try to write some test, will be necessary to configure test to deal with components. Please feel free to comment there and improve.

from otelbin.

bripkens avatar bripkens commented on May 30, 2024 1

Nope, not a blocker @samueljrz 👍. Cool that you are contributing ❤️ !

from otelbin.

bripkens avatar bripkens commented on May 30, 2024 1

Fixed by @samueljrz!

from otelbin.

roshan-gh avatar roshan-gh commented on May 30, 2024 1

@samueljrz Great job. Thank you for your contribution ❤️

from otelbin.

bripkens avatar bripkens commented on May 30, 2024

Hey @samueljrz,

if you are interested in contributing this, feel free to give it a shot! I suppose a fitting location for the download button could be here:

image

You can find the buttons within this file:

<Panel position="bottom-left" className="flex gap-x-3">
<ButtonGroup size={"xs"}>
<Tooltip>
<TooltipTrigger asChild>
<Button onClick={() => reactFlowInstance.zoomOut()} size="xs">
<Minus />
</Button>
</TooltipTrigger>
<TooltipContent>Zoom out</TooltipContent>
</Tooltip>
<Tooltip>
<TooltipTrigger asChild>
<Button onClick={() => reactFlowInstance.zoomIn()} size="xs">
<Plus />
</Button>
</TooltipTrigger>
<TooltipContent>Zoom in</TooltipContent>
</Tooltip>
</ButtonGroup>
<Tooltip>
<TooltipTrigger asChild>
<Button onClick={() => reactFlowInstance.fitView()} size="xs">
<Minimize2 />
</Button>
</TooltipTrigger>
<TooltipContent>Fit view</TooltipContent>
</Tooltip>
<Tooltip>
<TooltipTrigger asChild>
<Button className={locked ? "bg-primary" : undefined} onClick={() => setLocked(!locked)} size="xs">
<Lock className={locked ? "!text-button-icon-active" : ""} />
</Button>
</TooltipTrigger>
<TooltipContent>Toggle editor/visualization synchronization on cursor change</TooltipContent>
</Tooltip>
<Tooltip>
<TooltipTrigger asChild>
<Button onClick={() => openDialog(true)} size="xs">
<HelpCircle />
</Button>
</TooltipTrigger>
<TooltipContent>Show welcome dialog</TooltipContent>
</Tooltip>
</Panel>

from otelbin.

bripkens avatar bripkens commented on May 30, 2024

@samueljrz: Good suggestion, let's put it under share as you proposed! 👍

from otelbin.

samueljrz avatar samueljrz commented on May 30, 2024

I had some issues configuring the tests to understand ts and tsx, as the testEnvironment of one is ts-node and the other is jsdom to be able to render components under test. I'm looking for a way to solve it, is this a block?

All other nuances were solved.

from otelbin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.