GithubHelp home page GithubHelp logo

Comments (6)

mmanciop avatar mmanciop commented on May 29, 2024

Also, we need to contextualise the schema validation warnings:

# Learn more about the OpenTelemetry Collector via
# https://opentelemetry.io/docs/collector/

receivers:
  otlp:
    protocols:
      grpc:
      http:

processors:
  batch:
    ciao: # This should read "The configuration property 'ciao' is not allowed for the 'batch' processor"
  ciao: # This should read "The processor type 'ciao' is unknown"

ciao: # This should read "The 'ciao' top-element configuration is invalid"

exporters:
  otlp:
    endpoint: otelcol:4317

extensions:
  health_check:
  pprof:
  zpages:

service:
  extensions: [health_check, pprof, zpages]
  ciao:
  pipelines:
    ciao: # This should read "The type 'ciao' is not a known type of pipeline"
    traces:
      receivers: [otlp]
      processors: [batch]
      exporters: [otlp]
    metrics:
      receivers: [otlp]
      processors: [batch]
      exporters: [otlp]
    logs:
      receivers: [otlp]
      processors: [batch]
      exporters: [otlp]

from otelbin.

roshan-gh avatar roshan-gh commented on May 29, 2024

@mmanciop @bripkens As I communicated with monaco-yaml dev about contextualize the schema validation warnings, for now it's impossible to change the warnings, they are only can accessible as read-only data.

The data is generating from vscode-json-languageservice / yaml-language-server. (just as example: https://github.com/microsoft/vscode-json-languageservice/blob/main/src/services/jsonValidation.ts#L101))

In addition, yaml-language-server still uses vscode-nls, but vscode-json-languageservice has moved on to the new @ vscode/l10n. Updates in yaml-language-server may be needed.

Finally, I assume we can only improve the parts like @bripkens mentioned in the description of the issue

from otelbin.

mmanciop avatar mmanciop commented on May 29, 2024

@roshan-gh, are you saying that we cannot modify validation errors before they get to the editor?

from otelbin.

roshan-gh avatar roshan-gh commented on May 29, 2024

@mmanciop yes exactly

from otelbin.

bripkens avatar bripkens commented on May 29, 2024

Would it be possible to wrap the worker in some custom code and in there to update the texts @roshan-gh?

case "editorWorkerService":
return new Worker(new URL("monaco-editor/esm/vs/editor/editor.worker", import.meta.url));
case "yaml":
return new Worker(new URL("monaco-yaml/yaml.worker", import.meta.url));

from otelbin.

roshan-gh avatar roshan-gh commented on May 29, 2024

I will look into it and check it @bripkens

from otelbin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.