Comments (10)
cc @phofl
from dask.
Related to dask/dask-expr#526
from dask.
I am fine with switching to keep=None, I am also fine with warning if the user gives anything other than the default for keep and we would default to p2p shuffle, but I am -1 on choosing task based shuffling without the user specifically requesting it in these scenarios. Users should actively request tasks
from dask.
but I am -1 on choosing task based shuffling without the user specifically requesting it in these scenarios. Users should actively request tasks
Yeah, I suppose can understand that. I do think it is best to use the "stable" shuffle algorithm unless the user explicitly asks for "tasks". In that case, my only suggestion would be to warn the user that the results are likely to be "wrong" (as you already mentioned).
from dask.
@hendrikmakait with similar indexing foo as for arrays we should be able to make P2P stable, shouldn't we?
from dask.
Sure, guaranteed ordering is definitely possible. I'm not sure if indexing foo is sufficient or if we also need to make changes to guarantee ordering within shards but we can look into this.
from dask.
or if we also need to make changes to guarantee ordering within shards but we can look into this.
It seems like the groupby-based sharing should should preserve ordering on its own, no?
If there is motivation to avoid any modifications to the general "p2p" logic, what about the naive approach of (optionally) adding a "__source_partition"
column before the shuffle? If the shards themselves are ordered, then a uint16 column is probably all you need to sort the output partitions in most cases.
from dask.
It seems like the groupby-based sharing should should preserve ordering on its own, no?
How do you mean?
from dask.
How do you mean?
Sorry, I'm probably "thinking out loud" a bit too much. I was mis-remembering that the initial "sharding" in shuffle_transfer
/split_by_worker
was groupby based.
from dask.
For the drop_duplicates I believe there is a simple way to fix this, see #10722 (I may need to be a little more careful about when that sort is appropriate but I think it's not harmful)
I opened dask/distributed#8421 to discuss the possibility to make P2P stable but I don't consider this high prio right now
from dask.
Related Issues (20)
- Previously working time series resampling breaks in new version of Dask HOT 3
- When using PyArrow dtypes, aggregations create NaNs of unexpected type HOT 1
- Column with object dtype get converted to string when selecting the column HOT 1
- aggregate function that operates on vector(array of numeric) data
- Dask .head() returns error as .compute returns ok! HOT 2
- API docs missing for `read_csv`, `read_fwf` and `read_table` HOT 3
- New CI failure showing up in fsspec HOT 2
- Overlap with `new_axis` option is not trimmed correctly HOT 1
- ValueError: An error occurred while calling the read_csv method registered to the pandas backend HOT 2
- add a api load dataset from [huggingface datasets] HOT 4
- map_blocks returning pd.DataFrame fails with block_info parameter HOT 4
- Couple of sparse tests are failing HOT 1
- I'm not sure what βb_dictβ is, I couldn't find any relevant content HOT 1
- Release GH action needs to be run twice HOT 1
- gpuCI failing due to `pytest` warning HOT 5
- pandas>=2.0.0 incompatibility ?
- Concat with unknown divisions raises TypeError HOT 1
- Dask 2024.5.1 removed `.attrs` HOT 2
- Dask 2024.5.1 raises exception when `.compute()` is called on a categorical column HOT 3
- Scatter with broadcast=True does not broadcast
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dask.