Comments (5)
Are these checks added to the unit test or the source code?
from data-describe.
At least should be added to sanity checks prior to unit tests using tools like mypy. Adding types to source code may not be necessary yet.
from data-describe.
I'm new to static typing so I'm having trouble understanding where the checks should be located. If not in the source code, then would it be added to the unit testing code? Or is this an entirely new file?
from data-describe.
@truongc2 mypy
has CLI and you can use it together with flake8: https://github.com/ambv/flake8-mypy.
https://github.com/python/mypy#ide-linter-integrations-and-pre-commit
from data-describe.
More info for @truongc2:
Make sure you have installed pre-commit in your local dev environment
- Update
.pre-commit-config.yaml
to include mypy checks in addition to flake8 (which is already added). - Decide how mypy should be configured (args), See https://github.com/pre-commit/mirrors-mypy
- Test/run locally to ensure the mypy checks run and resolve any possible issues
- Merge to integrate with CI (Github Actions). Pre-commit is already implemented so there shouldn't be any additional change to activate
from data-describe.
Related Issues (20)
- feature importance: Return top N features
- Add plotly backend for feature importance
- Add % explained variance in the labels for the cluster plot
- documentation image links are missing in website
- data_summary: Exception: Internal Error HOT 2
- Add link to open in Google Colab
- Only the Cluster_Analysis.ipynb contains a menu option for plotly
- Unit test for feature importance should validate "top_features" arg
- Develop notebook examples for specific use cases such as sensor discovery, predictive maintenance, etc.
- Create example notebooks for more specific use cases HOT 2
- data_summary: Unexpected keyword error when running Data_Summary.ipynb in the examples folder HOT 5
- Site links are broken HOT 3
- Conda environment yamls should use pinned dependency versions
- Imputation functions for missing data HOT 1
- data_summary includes null values in top_frequency
- Add error message if input data is too large for specific widgets.
- seaborn_viz_plot_time_series kwargs
- Add mallet as an additional model_type for topic modeling
- Add kwargs for create_doc_term_matrix and create_doc_term_matrix when fitting the topic model
- Add jinja2 requirement
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from data-describe.