GithubHelp home page GithubHelp logo

Comments (3)

brianray avatar brianray commented on June 22, 2024

@terrytangyuan good to get your feedback on tox

from data-describe.

brianray avatar brianray commented on June 22, 2024

Little unclear if we need to put Python version in requirements.txt https://github.com/brianray/data-describe/blob/master/requirements.txt#L1
I suggest we also take that out.

TODO:

  • create tox.ini
  • add python instructions to README (if not there)
  • remove explicit "python" version in requirements.txt

from data-describe.

terrytangyuan avatar terrytangyuan commented on June 22, 2024

No, we should not have Python version in requirements.txt. However, we should explicitly specify the range of Python versions we support, an example here: https://github.com/tensorflow/io/blob/6505a6e6a6fd4e20bbdc09831a1489f4d26dbed2/setup.py#L137

Regarding tox, a couple of thoughts:

  • Tox is definitely good for local testing.
  • We are already building automated testing via GitHub Actions and can run multiple builds for different Python versions.
  • If we decide to run only one build on GitHub Actions via tox for multiple Python versions, tox might be more efficient as it might be able to leverage cache across various tests in a single build. GitHub Actions have ability to store cache as well but there might still be some additional overhead to spin up multiple builds.

from data-describe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.