Cannot overwrite DefaultServiceName when using OpenTracer about dd-trace-dotnet

[willyyang]

Service name does not get set when the Tracer is initialized.

   var x = Tracer.Create(uri, "testme");
   var span = Tracer.Instance.StartSpan("csharpSpan");

   Log.Debug(span.ServiceName); <-- returns server

[lucaspimentel]

Thanks for reporting this! It will be fixed in the next release.

[lucaspimentel]

@pgrm:

TL;DR: We are adding support for changing the service name on the underlying span when using OpenTracing.ISpan.SetTag() in #229.

Currently, the Datadog.Trace library (which Datadog.Trace.OpenTracing uses behind-the-scenes) does not allow changing a span's service name after the span is created. This feature will be added as part of a larger refactoring. When using the OpenTracing library, using ISpanBuilder.WithTag() before a span is created works correctly, but calling ISpan.SetTag() after the span is created would not.

[lucaspimentel]

@willyyang: Note that Tracer.Instance.StartSpan("csharpSpan") sets the operation name, not the service name. You want:

var span = Tracer.Instance.StartSpan("operation", serviceName: "service");

See:

dd-trace-dotnet/src/Datadog.Trace/Tracer.cs

Line 143 in cbf2af4

public Span StartSpan(string operationName, SpanContext childOf = null, string serviceName = null, DateTimeOffset? startTime = null, bool ignoreActiveScope = false)

Let's limit this issue to using OpenTracing.ISpan.SetTag() to change the service name after a span is created. If you have further problems with Tracer.Instance.StartSpan(), please open a new issue.

[lucaspimentel]

@pgrm: We just released v0.6.0. It allows you to change the service name with OpenTracing.ISpan.SetTag(), so I'm closing this issue. Thanks again!